Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Clean up diagnostic rules #107653

Closed
wants to merge 5 commits into from
Closed

[ONNX] Clean up diagnostic rules #107653

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f6600f
[ONNX] Clean up diagnostic rules
BowenBao Aug 22, 2023
d02b20a
adjust package name; remove xfail for unexpected pass on "[ONNX] Clea…
BowenBao Aug 22, 2023
3d5ef41
use commit from onnxscript main in CI on "[ONNX] Clean up diagnostic …
BowenBao Aug 22, 2023
7f11957
adjust xfail removal between commits; enable sarif log saving for uni…
BowenBao Aug 22, 2023
dff54ae
remove more xfails on "[ONNX] Clean up diagnostic rules"
BowenBao Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
63 changes: 6 additions & 57 deletions torch/csrc/onnx/diagnostics/generated/rules.h
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is codegen file, please ignore.

Original file line number Diff line number Diff line change
Expand Up @@ -36,56 +36,18 @@ enum class Rule : uint32_t {
kOperatorSupportedInNewerOpsetVersion,

/**
* @brief FX Tracer succeeded.
* @brief Transforms graph from FX IR to ONNX IR.
*/
kFxTracerSuccess,
kFxGraphToOnnx,

/**
* @brief FX Tracer failed.
*/
kFxTracerFailure,

/**
* @brief FX Tracer succeeded.
*/
kFxFrontendAotautograd,

/**
* @brief FX pass converting torch.neg to torch.sigmoid.
*/
kFxPassConvertNegToSigmoid,

/**
* @brief ToDo, experimenting diagnostics, placeholder text.
*/
kFxIrAddNode,

/**
* @brief Op level tracking. ToDo, experimenting diagnostics, placeholder
* text.
*/
kAtenlibSymbolicFunction,

/**
* @brief Graph level tracking. Each op is a step. ToDo, experimenting
* diagnostics, placeholder text.
*/
kAtenlibFxToOnnx,

/**
* @brief Node level tracking. ToDo, experimenting diagnostics, placeholder
* text.
* @brief Transforms an FX node to an ONNX node.
*/
kFxNodeToOnnx,

/**
* @brief The make_fx + decomposition pass on fx graph produced from Dynamo,
* before ONNX export.
*/
kFxFrontendDynamoMakeFx,

/**
* @brief FX graph transformation before ONNX export.
* @brief FX graph transformation during ONNX export before converting from FX
* IR to ONNX IR.
*/
kFxPass,

Expand Down Expand Up @@ -122,35 +84,22 @@ enum class Rule : uint32_t {
* registry.
*/
kFindOperatorOverloadsInOnnxRegistry,

/**
* @brief The formatted str for argument to display is too verbose.
*/
kArgFormatTooVerbose,
};

static constexpr const char* const kPyRuleNames[] = {
"node_missing_onnx_shape_inference",
"missing_custom_symbolic_function",
"missing_standard_symbolic_function",
"operator_supported_in_newer_opset_version",
"fx_tracer_success",
"fx_tracer_failure",
"fx_frontend_aotautograd",
"fx_pass_convert_neg_to_sigmoid",
"fx_ir_add_node",
"atenlib_symbolic_function",
"atenlib_fx_to_onnx",
"fx_graph_to_onnx",
"fx_node_to_onnx",
"fx_frontend_dynamo_make_fx",
"fx_pass",
"no_symbolic_function_for_call_function",
"unsupported_fx_node_analysis",
"op_level_debugging",
"find_opschema_matched_symbolic_function",
"fx_node_insert_type_promotion",
"find_operator_overloads_in_onnx_registry",
"arg_format_too_verbose",
};

} // namespace diagnostics
Expand Down