Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] More debug logging from fx to onnx #107654

Closed
wants to merge 5 commits into from
Closed

[ONNX] More debug logging from fx to onnx #107654

wants to merge 5 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Aug 22, 2023 •
edited

Stack from ghstack (oldest at bottom):

Summary:

  • Log fx graph name for 'fx-graph-to-onnx' diagnostic.
  • Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
  • Adjust unittest to run with diagnostics verbosity level logging.DEBUG.
  • Sarif logs will be saved for unittest when TORCH_LOGS="onnx_diagnostics" is set.
image

@BowenBao
[ONNX] More debug logging from fx to onnx
5b01edc 
Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.

[ghstack-poisoned]
@BowenBao BowenBao mentioned this pull request Aug 22, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 22, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107654

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b54050d with merge base 3f3479e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@BowenBao BowenBao mentioned this pull request Aug 22, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 22, 2023
@BowenBao BowenBao mentioned this pull request Aug 22, 2023
Closed
BowenBao added a commit that referenced this pull request Aug 22, 2023
@BowenBao
[ONNX] More debug logging from fx to onnx
2557307 
Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.

ghstack-source-id: 8c39c1a52241c6e8583eac3a2d38ba382abf778e
Pull Request resolved: #107654
@BowenBao BowenBao marked this pull request as ready for review August 22, 2023 01:14
@BowenBao BowenBao added the topic: improvements topic category label Aug 22, 2023
titaiwangms
titaiwangms approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to use the new api. Is there a page that I can learn?

torch/onnx/_internal/fx/fx_onnx_interpreter.py Show resolved Hide resolved
@justinchuby justinchuby added the module: onnx Related to torch.onnx label Aug 22, 2023
@BowenBao
adjust package name; remove xfail for unexpected pass on "[ONNX] More…
bd721e3 
… debug logging from fx to onnx"


Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.
<img width="640" alt="image" src="https://github.com/pytorch/pytorch/assets/9376104/a5718530-3594-46fb-85a2-b8bcc8ba01c7">


[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Aug 22, 2023
@BowenBao
[ONNX] More debug logging from fx to onnx
c46afc4 
Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.

ghstack-source-id: f284f21e68a05b8671bc4a804f5889f45c56e58a
Pull Request resolved: #107654
@BowenBao
use commit from onnxscript main in CI on "[ONNX] More debug logging f…
6172c60 
…rom fx to onnx"


Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.
<img width="640" alt="image" src="https://github.com/pytorch/pytorch/assets/9376104/a5718530-3594-46fb-85a2-b8bcc8ba01c7">


[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Aug 22, 2023
@BowenBao
[ONNX] More debug logging from fx to onnx
a49df18 
Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.

ghstack-source-id: d75c3a4f0df98682c05ff3342e7ee38d4be83c98
Pull Request resolved: #107654
@BowenBao
Copy link
Collaborator Author

Not sure how to use the new api. Is there a page that I can learn?

The docstrings and notes.

@BowenBao
adjust xfail removal between commits; enable sarif log saving for uni…
9807f52 
…ttest when logs enabled on "[ONNX] More debug logging from fx to onnx"


Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.
<img width="640" alt="image" src="https://github.com/pytorch/pytorch/assets/9376104/a5718530-3594-46fb-85a2-b8bcc8ba01c7">


[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Aug 22, 2023
@BowenBao
[ONNX] More debug logging from fx to onnx
10e116b 
Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.

ghstack-source-id: 935a3d3bb4c97b3ec54a85775118514c4cd01cfa
Pull Request resolved: #107654
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 22, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@BowenBao
remove more xfails on "[ONNX] More debug logging from fx to onnx"
b54050d 
Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.
- Sarif logs will be saved for unittest when `TORCH_LOGS="onnx_diagnostics"` is set.

<img width="640" alt="image" src="https://github.com/pytorch/pytorch/assets/9376104/a5718530-3594-46fb-85a2-b8bcc8ba01c7">


[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Aug 23, 2023
@BowenBao
[ONNX] More debug logging from fx to onnx
1e9bed2 
Summary:
- Log fx graph name for 'fx-graph-to-onnx' diagnostic.
- Log fx graph and onnx graph under DEBUG verbosity level for 'fx-graph-to-onnx' diagnostic.
- Adjust unittest to run with diagnostics verbosity level logging.DEBUG.

ghstack-source-id: 2a6c0a52e50f81d028a8f6c92d61c57e9bf24a6f
Pull Request resolved: #107654
@BowenBao
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/291/head branch August 27, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@titaiwangms titaiwangms titaiwangms approved these changes

@abock abock Awaiting requested review from abock

@thiagocrepaldi thiagocrepaldi Awaiting requested review from thiagocrepaldi

@wschin wschin Awaiting requested review from wschin

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
ONNX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BowenBao @pytorchmergebot @justinchuby @titaiwangms @pytorchbot