-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPS] Add complex support for fill
#111885
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111885
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e4fad99 with merge base fb88760 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 3d80018585a6a8094cf6c263b4317e0aca16047c Pull Request resolved: #111885
fill
[ghstack-poisoned]
ghstack-source-id: 01c4b115d47a44dc9a329d266fbd80e3847526d2 Pull Request resolved: #111885
[ghstack-poisoned]
ghstack-source-id: 35c0a700d5369f39fdca756fa60ffc63d6202345 Pull Request resolved: #111885
fill_scalar_mps_impl(self_as_real_real, Scalar(value_cdouble.real())); | ||
fill_scalar_mps_impl(self_as_real_imag, Scalar(value_cdouble.imag())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fill_scalar_mps_impl(self_as_real_real, Scalar(value_cdouble.real())); | |
fill_scalar_mps_impl(self_as_real_imag, Scalar(value_cdouble.imag())); | |
fill_scalar_mps_impl(self_as_real_real, value_cdouble.real()); | |
fill_scalar_mps_impl(self_as_real_imag, value_cdouble.imag()); |
Fixes #110537 [ghstack-poisoned]
ghstack-source-id: 7acafed6ce55d47e6ac37231eb15ca9d2cb35b9b Pull Request resolved: #111885
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes pytorch#110537 Pull Request resolved: pytorch#111885 Approved by: https://github.com/malfet
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: #111937 Approved by: https://github.com/malfet ghstack dependencies: #111885
Fixes pytorch#110537 Pull Request resolved: pytorch#111885 Approved by: https://github.com/malfet
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: pytorch#111937 Approved by: https://github.com/malfet ghstack dependencies: pytorch#111885
Fixes pytorch#110537 Pull Request resolved: pytorch#111885 Approved by: https://github.com/malfet
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: pytorch#111937 Approved by: https://github.com/malfet ghstack dependencies: pytorch#111885
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: pytorch#111937 Approved by: https://github.com/malfet ghstack dependencies: pytorch#111885
Stack from ghstack (oldest at bottom):
fill
#111885Fixes #110537