[MPS] Fix bug when value is of complex #111937
Conversation
[ghstack-poisoned]
pytorch-bot
bot
added
ciflow/mps
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111937
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a3a5c61 with merge base fb88760 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 3472574f54a6e4da784db3ba1f626f8643686e2f Pull Request resolved: #111937
[ghstack-poisoned]
ghstack-source-id: 66186be870fa49fb3ddb1551baceed22b4d5e579 Pull Request resolved: #111937
[ghstack-poisoned]
ghstack-source-id: 95acb1f1c30fa0eec9aad48c5da78f0637ce617f Pull Request resolved: #111937
|
Hi @malfet, can you please take a look? as there is a bug in the first PR. |
|
@qqaatw Can you add a bit longer description what exactly regressed? And yes, unit tests are good thing, aren't they? |
Sure, added a description. Nothing regressed, I just didn't do the thing well so I'm fixing it. Yes unit tests are great, I agree. |
|
Hi @malfet, does this PR look good to you now? |
|
@pytorchbot merge -f "MPS tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: pytorch#111937 Approved by: https://github.com/malfet ghstack dependencies: pytorch#111885
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: pytorch#111937 Approved by: https://github.com/malfet ghstack dependencies: pytorch#111885
When the value of `fill` is of complex, this line `value.toDouble() == 0.0` will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition. Pull Request resolved: pytorch#111937 Approved by: https://github.com/malfet ghstack dependencies: pytorch#111885
Stack from ghstack (oldest at bottom):
fill#111885When the value of
fillis of complex, this linevalue.toDouble() == 0.0will error out saying that converting complex to double will cause overflow. So we should firstly handle the complex value and then enter this condition.