[optim/dynamo] shortcut adagrad with has_complex
#112722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-chuang
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol,
fegin,
fduwjj,
kiukchung,
d4l3k,
wz337,
albanD and
janeyx99
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112722
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 7fc0c32 with merge base 68dead4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jon-chuang
removed request for
kwen2501,
fduwjj,
rohan-varma,
wanchaol,
H-Huang,
mrshenli,
awgu,
wz337,
kiukchung and
zhaojuanmao
jon-chuang
requested review from
mlazos,
albanD and
janeyx99
and removed request for
mrshenli,
awgu,
wz337,
janeyx99,
kiukchung and
zhaojuanmao
…uang/adagrad-shortcut-has-complex
albanD
approved these changes
Nov 2, 2023
albanD
added
the
triaged
|
There are existing tests for pytorch/test/optim/test_optim.py Line 1503 in a1ab22b |
|
The compile + complex path is currently IIRC untested so that could honestly be improved. Created an issue: #112731 |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Follow up to pytorch#110706, it was missed as depended on another fix Pull Request resolved: pytorch#112722 Approved by: https://github.com/albanD
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Follow up to pytorch#110706, it was missed as depended on another fix Pull Request resolved: pytorch#112722 Approved by: https://github.com/albanD
andreigh
pushed a commit
to andreigh/pytorch
that referenced
this pull request
Nov 19, 2023
Follow up to pytorch#110706, it was missed as depended on another fix Pull Request resolved: pytorch#112722 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #110706, it was missed as depended on another fix
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng