-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Open
Labels
actionablegood first issueinternal ramp-up taskTasks that are suitable for new folks w/ high-touch guidance from senior PyTorch folksTasks that are suitable for new folks w/ high-touch guidance from senior PyTorch folksmodule: dynamomodule: optimizerRelated to torch.optimRelated to torch.optimmodule: testsIssues related to tests (not the torch.testing module)Issues related to tests (not the torch.testing module)oncall: pt2triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🚀 The feature, motivation and pitch
Even though we allow tracing complex and sparse grads for optimizers, we do not test that these actually work
Solution
Copy some of the tests from test_optim e.g.
https://github.com/pytorch/pytorch/blob/main/test/optim/test_optim.py
into
https://github.com/pytorch/pytorch/blob/main/test/dynamo/test_optimizers.py
Alternatives
Not tested
cc @vincentqb @jbschlosser @albanD @janeyx99 @crcrpar @mruberry @ZainRizvi @ezyang @anijain2305 @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @msaroufim @wconstab @bdhirsh @zou3519 @aakhundov
janeyx99
Metadata
Metadata
Assignees
Labels
actionablegood first issueinternal ramp-up taskTasks that are suitable for new folks w/ high-touch guidance from senior PyTorch folksTasks that are suitable for new folks w/ high-touch guidance from senior PyTorch folksmodule: dynamomodule: optimizerRelated to torch.optimRelated to torch.optimmodule: testsIssues related to tests (not the torch.testing module)Issues related to tests (not the torch.testing module)oncall: pt2triagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module