[BE] Make legacy type storage warning point to the caller #113601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@classproperty` adds another wrapper, so warning would always point to the wrapper implementation rather than at callee. For example, before this change following code ```python import torch print(torch.FloatStorage.dtype) ``` will produce inactionable warning: ``` /Users/nshulga/git/pytorch/pytorch/torch/_utils.py:836: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly. To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage() return self.fget.__get__(instance, owner)() ``` But after the change warning turns into: ``` /Users/nshulga/test/bar.py:2: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly. To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage() print(torch.FloatStorage.dtype) ```
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113601
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d459f16 with merge base a43c757 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
Nov 14, 2023
|
I have a global ruff rule to ban warnings without an explicit stack level, but I haven't gotten around to enabling it. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…3601) `@classproperty` decorator adds another wrapper, so warning with default stacklevel (2) would always point to the wrapper implementation rather than at callee. For example, before this change following code ```python import torch print(torch.FloatStorage.dtype) ``` will produce inactionable warning: ``` /Users/nshulga/git/pytorch/pytorch/torch/_utils.py:836: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly. To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage() return self.fget.__get__(instance, owner)() ``` But after the change warning turns into: ``` /Users/nshulga/test/bar.py:2: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly. To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage() print(torch.FloatStorage.dtype) ``` Discovered while reading pytorch#109108 Pull Request resolved: pytorch#113601 Approved by: https://github.com/kit1980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@classpropertydecorator adds another wrapper, so warning with default stacklevel (2) would always point to the wrapper implementation rather than at callee.For example, before this change following code
will produce inactionable warning:
But after the change warning turns into:
Discovered while reading #109108