Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete 2.29 libstdc++ from jammy builds #121547

Closed
wants to merge 1 commit into from
Closed

Delete 2.29 libstdc++ from jammy builds #121547

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Mar 8, 2024

They somehow magically worked, but this is very fragile and also results in a build warnings about missing libcxx magic

@malfet
Delete 2.29 libstdc++ from jammy builds
42b5cd9 
They somehow magically worked, but this is very fragile and also results in a build warnings about missing libcxx magic
@malfet malfet requested a review from jeffdaily as a code owner March 8, 2024 22:23
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 8, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 8, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121547

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures, 13 Unrelated Failures

As of commit 42b5cd9 with merge base 2c2d6ce (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn mentioned this pull request Mar 12, 2024
Closed
manuelcandales pushed a commit to manuelcandales/executorch-1 that referenced this pull request Mar 13, 2024
@huydhn @facebook-github-bot
Fix doc build GLIBCXX_3.4.30 not found (pytorch#2376)
4670211 
Summary:
The hack is from pytorch/pytorch#121547.  This is to fix the failing doc build on 22.04, i.e. https://github.com/pytorch/executorch/actions/runs/8167685547/job/22328481328

```
ImportError: /opt/conda/envs/py_3.10/bin/../lib/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by /opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/lib/libtorch_python.so)
```

Pull Request resolved: pytorch#2376

Reviewed By: guangy10

Differential Revision: D54818139

Pulled By: huydhn

fbshipit-source-id: aad8408908ef52f15a32395c31cc1698cd337c6b
@malfet
Copy link
Contributor Author

malfet commented Mar 13, 2024

Closing in favor of #121556

@malfet malfet closed this Mar 13, 2024
@github-actions github-actions bot deleted the malfet-patch-3 branch April 13, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@huydhn huydhn huydhn approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees
No one assigned
Labels
topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malfet @kit1980 @huydhn @Skylion007