New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quant][graphmode][fx][eagermode] Add leaky relu support in quantization workflows #45712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion workflows Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 2, 2020
…n quantization workflows" Summary: Eager mode will still be able to use functional leaky relu, but it will be less accurate than LeakyReLU module. FX graph mode will support both leaky relu functional and module Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…n quantization workflows" Summary: Eager mode will still be able to use functional leaky relu, but it will be less accurate than LeakyReLU module. FX graph mode will support both leaky relu functional and module Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/jerryzh168/450/base #45712 +/- ##
=======================================================
Coverage 68.32% 68.33%
=======================================================
Files 410 410
Lines 52994 52992 -2
=======================================================
Hits 36210 36210
+ Misses 16784 16782 -2
Continue to review full report at Codecov.
|
…n quantization workflows" Summary: Eager mode will still be able to use functional leaky relu, but it will be less accurate than LeakyReLU module. FX graph mode will support both leaky relu functional and module Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24069961](https://our.internmc.facebook.com/intern/diff/D24069961) [ghstack-poisoned]
z-a-f
approved these changes
Oct 5, 2020
…n quantization workflows" Summary: Eager mode will still be able to use functional leaky relu, but it will be less accurate than LeakyReLU module. FX graph mode will support both leaky relu functional and module Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24069961](https://our.internmc.facebook.com/intern/diff/D24069961) [ghstack-poisoned]
This was referenced Oct 6, 2020
This pull request has been merged in 0da6730. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Eager mode will still be able to use functional leaky relu, but it will be less accurate than
LeakyReLU module.
FX graph mode will support both leaky relu functional and module
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24069961