[quant][eagermode] Add support for sigmoid module #45884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: python test/test_quantization.py TestEagerModeOps.test_sigmoid Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Oct 6, 2020
z-a-f
approved these changes
Oct 6, 2020
Summary: Test Plan: python test/test_quantization.py TestEagerModeOps.test_sigmoid Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24129115](https://our.internmc.facebook.com/intern/diff/D24129115) [ghstack-poisoned]
This was referenced Oct 6, 2020
Summary: Test Plan: python test/test_quantization.py TestEagerModeOps.test_sigmoid Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24129115](https://our.internmc.facebook.com/intern/diff/D24129115) [ghstack-poisoned]
Summary: Test Plan: python test/test_quantization.py TestEagerModeOps.test_sigmoid Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24129115](https://our.internmc.facebook.com/intern/diff/D24129115) [ghstack-poisoned]
raghuramank100
approved these changes
Oct 7, 2020
Summary: Test Plan: python test/test_quantization.py TestEagerModeOps.test_sigmoid Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D24129115](https://our.internmc.facebook.com/intern/diff/D24129115) [ghstack-poisoned]
|
we'll use fixed quantization parameter for sigmoid since there are implementations that only implements sigmoid with fixed quantization parameters, e.g. qnnpack: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/quantized/cpu/qnnpack/src/sigmoid.c#L72, and it uses LUT as an optimization. this can't be done if we support arbitrary output_scale and output_zero_point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
python test/test_quantization.py TestEagerModeOps.test_sigmoid
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24129115