[quant][graphmode][fx] Add warning for unsupported case #45714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Hit the problem when writing a test like following:
```
class M(...):
def forward(self, x):
x = x.some_op()
return x
```
we need to know the scope of `x` to figure out the qconfig for `x`
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
[ghstack-poisoned]
This was referenced Oct 2, 2020
Summary:
Hit the problem when writing a test like following:
```
class M(...):
def forward(self, x):
x = x.some_op()
return x
```
we need to know the scope of `x` to figure out the qconfig for `x`
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
[ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 2, 2020
Summary:
Hit the problem when writing a test like following:
```
class M(...):
def forward(self, x):
x = x.some_op()
return x
```
we need to know the scope of `x` to figure out the qconfig for `x`
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
ghstack-source-id: 20bb60fa4a8a016a5558ad0c3d6b828a5d607ccf
Pull Request resolved: #45714
Summary:
Hit the problem when writing a test like following:
```
class M(...):
def forward(self, x):
x = x.some_op()
return x
```
we need to know the scope of `x` to figure out the qconfig for `x`
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D24069959](https://our.internmc.facebook.com/intern/diff/D24069959)
[ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Oct 5, 2020
Summary:
Hit the problem when writing a test like following:
```
class M(...):
def forward(self, x):
x = x.some_op()
return x
```
we need to know the scope of `x` to figure out the qconfig for `x`
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
ghstack-source-id: 3d3fe552470707374782ba89272d7d4473d1df13
Pull Request resolved: #45714
z-a-f
approved these changes
Oct 5, 2020
Codecov Report
@@ Coverage Diff @@
## gh/jerryzh168/451/base #45714 +/- ##
==========================================================
- Coverage 68.33% 68.33% -0.01%
==========================================================
Files 410 410
Lines 52992 52997 +5
==========================================================
+ Hits 36210 36213 +3
- Misses 16782 16784 +2
Continue to review full report at Codecov.
|
Summary:
Hit the problem when writing a test like following:
```
class M(...):
def forward(self, x):
x = x.some_op()
return x
```
we need to know the scope of `x` to figure out the qconfig for `x`
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D24069959](https://our.internmc.facebook.com/intern/diff/D24069959)
[ghstack-poisoned]
This was referenced Oct 6, 2020
Summary:
Hit the problem when writing a test like following:
```
class M(...):
def forward(self, x):
x = x.some_op()
return x
```
we need to know the scope of `x` to figure out the qconfig for `x`
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: [D24069959](https://our.internmc.facebook.com/intern/diff/D24069959)
[ghstack-poisoned]
This was referenced Oct 6, 2020
|
This pull request has been merged in 14997f2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Hit the problem when writing a test like following:
we need to know the scope of
xto figure out the qconfig forxTest Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D24069959