Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline API to accept arbitrary sequence of Tensors and not just Tuple #48467

Closed

Conversation

pritamdamania87
Copy link
Contributor

@pritamdamania87 pritamdamania87 commented Nov 26, 2020

Stack from ghstack:

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: D25181944

…ust Tuple

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented Nov 26, 2020

💊 CI failures summary and remediations

As of commit 9f84d16 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Dec 12 00:00:30 AssertionError: mypy failed: tools/codegen/gen.py:388:9: error: Missing return statement
Dec 12 00:00:08   test_run_mypy (__main__.TestTypeHints) ... ok (58.625s)
Dec 12 00:00:11   test_run_mypy_strict (__main__.TestTypeHints) ... FAIL (2.755s)
Dec 12 00:00:30   test_type_hint_examples (__main__.TestTypeHints) ... ok (19.286s)
Dec 12 00:00:30 
Dec 12 00:00:30 ======================================================================
Dec 12 00:00:30 FAIL [2.755s]: test_run_mypy_strict (__main__.TestTypeHints)
Dec 12 00:00:30 ----------------------------------------------------------------------
Dec 12 00:00:30 Traceback (most recent call last):
Dec 12 00:00:30   File "test_type_hints.py", line 239, in test_run_mypy_strict
Dec 12 00:00:30     self.fail(f"mypy failed: {stdout} {stderr}")
Dec 12 00:00:30 AssertionError: mypy failed: tools/codegen/gen.py:388:9: error: Missing return statement
Dec 12 00:00:30 Found 1 error in 1 file (checked 11 source files)
Dec 12 00:00:30  
Dec 12 00:00:30 
Dec 12 00:00:30 ----------------------------------------------------------------------
Dec 12 00:00:30 Ran 4 tests in 91.234s
Dec 12 00:00:30 
Dec 12 00:00:30 FAILED (failures=1)
Dec 12 00:00:30 
Dec 12 00:00:30 Generating XML reports...
Dec 12 00:00:30 Generated XML report: test-reports/dist-gloo/TEST-TestTypeHints-20201211235859.xml

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 51 times.

…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Nov 26, 2020
…ust Tuple

Pull Request resolved: #48467

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.
ghstack-source-id: 117378410

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)
Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Nov 30, 2020
…ust Tuple

Pull Request resolved: #48467

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.
ghstack-source-id: 117494175

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)
…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Dec 8, 2020
…ust Tuple

Pull Request resolved: #48467

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.
ghstack-source-id: 118064543

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)
…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Dec 8, 2020
…ust Tuple

Pull Request resolved: #48467

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.
ghstack-source-id: 118100143

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)
…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Dec 10, 2020
…ust Tuple

Pull Request resolved: #48467

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.
ghstack-source-id: 118253023

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)
…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
…s and not just Tuple"

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Dec 11, 2020
…ust Tuple

Pull Request resolved: #48467

The current API's forward method only accepted a Tensor or a Tuple of
Tensors, making this more generic by accepting any Sequence of Tensors.
ghstack-source-id: 118436340

Differential Revision: [D25181944](https://our.internmc.facebook.com/intern/diff/D25181944/)
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in dc4db95.

@facebook-github-bot facebook-github-bot deleted the gh/pritamdamania87/183/head branch December 16, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants