New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reland] Remove balance
and devices
parameter from Pipe.
#48432
[reland] Remove balance
and devices
parameter from Pipe.
#48432
Conversation
As per our design in #44827, changign the API such that the user places modules on appropriate devices instead of having a `balance` and `devices` parameter that decides this. This design allows us to use RemoteModule in the future. ghstack-source-id: 116479842 Differential Revision: [D25172970](https://our.internmc.facebook.com/intern/diff/D25172970/) [ghstack-poisoned]
As per our design in #44827, changign the API such that the user places modules on appropriate devices instead of having a `balance` and `devices` parameter that decides this. This design allows us to use RemoteModule in the future. ghstack-source-id: 116479842 Differential Revision: [D25172970](https://our.internmc.facebook.com/intern/diff/D25172970/) ghstack-source-id: 117361676 Pull Request resolved: #48432
💊 CI failures summary and remediationsAs of commit 4b41445 (more details on the Dr. CI page):
3 failures not recognized by patterns:
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
As per our design in #44827, changign the API such that the user places modules on appropriate devices instead of having a `balance` and `devices` parameter that decides this. This design allows us to use RemoteModule in the future. Differential Revision: [D25172970](https://our.internmc.facebook.com/intern/diff/D25172970/) [ghstack-poisoned]
Pull Request resolved: #48432 As per our design in #44827, changign the API such that the user places modules on appropriate devices instead of having a `balance` and `devices` parameter that decides this. This design allows us to use RemoteModule in the future. ghstack-source-id: 117378115 ghstack-source-id: 117378115 Differential Revision: [D25172970](https://our.internmc.facebook.com/intern/diff/D25172970/)
Codecov Report
@@ Coverage Diff @@
## gh/pritamdamania87/182/base #48432 +/- ##
===============================================================
- Coverage 80.91% 80.76% -0.15%
===============================================================
Files 1855 1856 +1
Lines 200241 200130 -111
===============================================================
- Hits 162023 161639 -384
- Misses 38218 38491 +273 |
balance
and devices
parameter from Pipe.balance
and devices
parameter from Pipe.
As per our design in #44827, changign the API such that the user places modules on appropriate devices instead of having a `balance` and `devices` parameter that decides this. This design allows us to use RemoteModule in the future. Differential Revision: [D25172970](https://our.internmc.facebook.com/intern/diff/D25172970/) [ghstack-poisoned]
Pull Request resolved: #48432 As per our design in #44827, changign the API such that the user places modules on appropriate devices instead of having a `balance` and `devices` parameter that decides this. This design allows us to use RemoteModule in the future. ghstack-source-id: 117491992 ghstack-source-id: 117491992 Differential Revision: [D25172970](https://our.internmc.facebook.com/intern/diff/D25172970/)
|
||
with pytest.raises( | ||
ValueError, | ||
match=r'should have all parameters on a single device, please use .to\(\)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message matching has changed and was failing lint earlier to the escape sequence \(
This pull request has been merged in 7c73fda. |
1 similar comment
This pull request has been merged in 7c73fda. |
Stack from ghstack:
balance
anddevices
parameter from Pipe. #48432 [reland] Removebalance
anddevices
parameter from Pipe.As per our design in #44827,
changign the API such that the user places modules on appropriate devices
instead of having a
balance
anddevices
parameter that decides this.This design allows us to use RemoteModule in the future.
Differential Revision: D25172970