Modify Pipe to return an RRef. #47829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/) [ghstack-poisoned]
pritamdamania87
requested review from
apaszke,
mingzhe09088,
mrshenli,
pietern,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 12, 2020
As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/) ghstack-source-id: 116499310 Pull Request resolved: #47829
💊 CI failures summary and remediationsAs of commit d03229f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 41 times. |
rohan-varma
reviewed
Nov 19, 2020
rohan-varma
reviewed
Nov 19, 2020
| import tempfile | ||
|
|
||
| @pytest.fixture | ||
| def setup_rpc(scope="session"): |
There was a problem hiding this comment.
Looks like this function isn't used?
There was a problem hiding this comment.
It's actually used as part of input to the test fixtures (ex: test_1to3).
rohan-varma
approved these changes
Nov 19, 2020
As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 25, 2020
Pull Request resolved: #47829 As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. ghstack-source-id: 117361908 Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/)
As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 26, 2020
Pull Request resolved: #47829 As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. ghstack-source-id: 117378144 Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/)
This was referenced Nov 26, 2020
As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 30, 2020
Pull Request resolved: #47829 As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. ghstack-source-id: 117494044 Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/)
This was referenced Dec 1, 2020
As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Dec 8, 2020
Pull Request resolved: #47829 As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. ghstack-source-id: 118064022 Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/)
As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Dec 10, 2020
Pull Request resolved: #47829 As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. ghstack-source-id: 118252711 Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/)
As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/) [ghstack-poisoned]
As per proposal in #44827, the API needs to return an RRef to support inter-host pipelining. For now, we just return a local RRef and only support pipeline on a single host. But having this change in the API upfront ensures we don't make any BC breaking changes later. Differential Revision: [D24914022](https://our.internmc.facebook.com/intern/diff/D24914022/) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
As per proposal in #44827,
the API needs to return an RRef to support inter-host pipelining.
For now, we just return a local RRef and only support pipeline on a single
host. But having this change in the API upfront ensures we don't make any BC
breaking changes later.
Differential Revision: D24914022