Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Symbolic function for torch.square #49446

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

jiafatom
Copy link
Contributor

As titled. Implement by using onnx Mul operator to self-multiply. Unit test added.

@jiafatom jiafatom changed the title Symbolic function for torch.square [ONNX] Symbolic function for torch.square Dec 16, 2020
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 16, 2020

💊 CI failures summary and remediations

As of commit 38d660d (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 3 times.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #49446 (38d660d) into onnx_ms_1 (5912316) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

@@              Coverage Diff              @@
##           onnx_ms_1   #49446      +/-   ##
=============================================
- Coverage      80.63%   80.63%   -0.01%     
=============================================
  Files           1875     1875              
  Lines         202714   202722       +8     
=============================================
+ Hits          163453   163458       +5     
- Misses         39261    39264       +3     

Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spandantiwari spandantiwari merged commit 203e181 into pytorch:onnx_ms_1 Dec 17, 2020
BowenBao pushed a commit that referenced this pull request Dec 22, 2020
BowenBao pushed a commit that referenced this pull request Jan 4, 2021
BowenBao added a commit that referenced this pull request Jan 5, 2021
* update symbolic for unfold

* update symbolic_opse12 file

* update symbolic_opse12 file

* [ONNX] Support onnx if/loop sequence output in opset 13 - (#49270)

* Symbolic function for torch.square (#49446)

* instead of a pass use a helper function

* update ort version

* Revert "instead of a pass use a helper function"

This reverts commit 723b446.

* update symbolics

* update symbolic

* update symbolics

* [ONNX] Support onnx if/loop sequence output in opset 13 - (#49270)

* Symbolic function for torch.square (#49446)

* empty commit

* fix clang-tidy

* fix clang-tidy

Co-authored-by: Bowen Bao <bowbao@microsoft.com>
Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>
BowenBao added a commit that referenced this pull request Jan 5, 2021
…it is as same as inputs. (#49798)

* [ONNX] Support onnx if/loop sequence output in opset 13 - (#49270)

* Symbolic function for torch.square (#49446)

* [ONNX] Support onnx if/loop sequence output in opset 13 - (#49270)

* Symbolic function for torch.square (#49446)

* Update code so that initializers' sequence is as same as inputs.

* Correct the format according to flake8.

* Correct the format by clang-format.

* Add a new test for script model.

* Update expect files for Test_Operators tests.

Co-authored-by: Bowen Bao <bowbao@microsoft.com>
Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>
neginraoof added a commit that referenced this pull request Jan 6, 2021
* Enable opset 13 ORT tests

* Update test.sh

* Set environ var

* Update test.sh

* Enabling more ops for opset 13

* change master to main

* Update symbolic_opset13.py

* Flake 8 fix

* [ONNX] Support onnx if/loop sequence output in opset 13 - (#49270)

* Symbolic function for torch.square (#49446)

* Clean up tests

* Exclude more tests

* Trigge build

* [ONNX] Support onnx if/loop sequence output in opset 13 - (#49270)

* Symbolic function for torch.square (#49446)

* update ORT version

* disable more tests

* clean up

* flake8

* Disable TV tests

* Update test_pytorch_onnx_onnxruntime.py

Co-authored-by: Bowen Bao <bowbao@microsoft.com>
Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>
spandantiwari pushed a commit to spandantiwari/pytorch that referenced this pull request Jan 8, 2021
spandantiwari pushed a commit to spandantiwari/pytorch that referenced this pull request Jan 8, 2021
* update symbolic for unfold

* update symbolic_opse12 file

* update symbolic_opse12 file

* [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270)

* Symbolic function for torch.square (pytorch#49446)

* instead of a pass use a helper function

* update ort version

* Revert "instead of a pass use a helper function"

This reverts commit 723b446.

* update symbolics

* update symbolic

* update symbolics

* [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270)

* Symbolic function for torch.square (pytorch#49446)

* empty commit

* fix clang-tidy

* fix clang-tidy

Co-authored-by: Bowen Bao <bowbao@microsoft.com>
Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>
spandantiwari pushed a commit to spandantiwari/pytorch that referenced this pull request Jan 8, 2021
…it is as same as inputs. (pytorch#49798)

* [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270)

* Symbolic function for torch.square (pytorch#49446)

* [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270)

* Symbolic function for torch.square (pytorch#49446)

* Update code so that initializers' sequence is as same as inputs.

* Correct the format according to flake8.

* Correct the format by clang-format.

* Add a new test for script model.

* Update expect files for Test_Operators tests.

Co-authored-by: Bowen Bao <bowbao@microsoft.com>
Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>
spandantiwari pushed a commit to spandantiwari/pytorch that referenced this pull request Jan 8, 2021
* Enable opset 13 ORT tests

* Update test.sh

* Set environ var

* Update test.sh

* Enabling more ops for opset 13

* change master to main

* Update symbolic_opset13.py

* Flake 8 fix

* [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270)

* Symbolic function for torch.square (pytorch#49446)

* Clean up tests

* Exclude more tests

* Trigge build

* [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270)

* Symbolic function for torch.square (pytorch#49446)

* update ORT version

* disable more tests

* clean up

* flake8

* Disable TV tests

* Update test_pytorch_onnx_onnxruntime.py

Co-authored-by: Bowen Bao <bowbao@microsoft.com>
Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>
facebook-github-bot pushed a commit that referenced this pull request Jan 13, 2021
Summary:
[ONNX] ONNX dev branch merge 01-06-2021
- [ONNX] Support onnx if/loop sequence output in opset 13 - (#49270)
- Symbolic function for torch.square (#49446)
- [ONNX] Add checks in ONNXSetDynamicInputShape (#49783) …
- [ONNX] Enable export af aten::__derive_index (#49514) …
- [ONNX] Update symbolic for unfold (#49378) …
- [ONNX] Update the sequence of initializers in exported graph so that it is as same as inputs. (#49798)
- [ONNX] Enable opset 13 ops (#49612) …
- [ONNX] Improve error message for supported model input types in ONNX export API. (#50119)
- [ONNX] Add a post-pass for If folding (#49410)

Pull Request resolved: #50163

Reviewed By: pbelevich

Differential Revision: D25821059

Pulled By: SplitInfinity

fbshipit-source-id: 9f511a93d9d5812d0ab0a49d61ed0fa5f8066948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants