[ONNX] Update symbolic for unfold #49378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiafatom
reviewed
Dec 16, 2020
|
@KsenijaS - is this change is just for Opset 12 then the PR title should reflect it. Also, the description does not full explain the current problem (or mention anything about current support in Opset 9). You should flesh out the PR description more. |
BowenBao
reviewed
Dec 18, 2020
This reverts commit 723b446.
|
clang-tidy errors are not related to my changes. |
BowenBao
approved these changes
Jan 5, 2021
spandantiwari
pushed a commit
to spandantiwari/pytorch
that referenced
this pull request
Jan 8, 2021
* update symbolic for unfold * update symbolic_opse12 file * update symbolic_opse12 file * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * instead of a pass use a helper function * update ort version * Revert "instead of a pass use a helper function" This reverts commit 723b446. * update symbolics * update symbolic * update symbolics * [ONNX] Support onnx if/loop sequence output in opset 13 - (pytorch#49270) * Symbolic function for torch.square (pytorch#49446) * empty commit * fix clang-tidy * fix clang-tidy Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: David Fan <30608893+jiafatom@users.noreply.github.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 13, 2021
Summary: [ONNX] ONNX dev branch merge 01-06-2021 - [ONNX] Support onnx if/loop sequence output in opset 13 - (#49270) - Symbolic function for torch.square (#49446) - [ONNX] Add checks in ONNXSetDynamicInputShape (#49783) … - [ONNX] Enable export af aten::__derive_index (#49514) … - [ONNX] Update symbolic for unfold (#49378) … - [ONNX] Update the sequence of initializers in exported graph so that it is as same as inputs. (#49798) - [ONNX] Enable opset 13 ops (#49612) … - [ONNX] Improve error message for supported model input types in ONNX export API. (#50119) - [ONNX] Add a post-pass for If folding (#49410) Pull Request resolved: #50163 Reviewed By: pbelevich Differential Revision: D25821059 Pulled By: SplitInfinity fbshipit-source-id: 9f511a93d9d5812d0ab0a49d61ed0fa5f8066948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for dynamic inputs size and step of unfold operator in Opset 12.
Currently this operator only support constant inputs for opsets 9 and above.
fixes: #47182