fx quant: types for fusion_patterns.py #49606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds more types, for readability. Test Plan: ``` mypy torch/quantization ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Dec 18, 2020
💊 CI failures summary and remediationsAs of commit 7b9f6b1 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 5 times. |
jerryzh168
approved these changes
Dec 18, 2020
This was referenced Dec 18, 2020
Summary: Adds more types, for readability. Test Plan: ``` mypy torch/quantization ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25643894](https://our.internmc.facebook.com/intern/diff/D25643894) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/192/base #49606 +/- ##
=====================================================
- Coverage 80.55% 80.55% -0.01%
=====================================================
Files 1887 1887
Lines 204600 204607 +7
=====================================================
- Hits 164825 164823 -2
- Misses 39775 39784 +9 |
|
This pull request has been merged in 9d5d193. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49606 Adds more types, for readability. Test Plan: ``` mypy torch/quantization ``` Imported from OSS Reviewed By: jerryzh168 Differential Revision: D25643894 fbshipit-source-id: 4aad52fe4e59ad74b6e0e3acd0f98fba91561a29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds more types, for readability.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25643894