fx quant: fix types on _find_quants #49616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add types to `_find_quants` I/O and fix resulting errors, needed for an upcoming bug fix. Test Plan: ``` mypy torch/quantization python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Dec 18, 2020
💊 CI failures summary and remediationsAs of commit 7b80f03 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
jerryzh168
reviewed
Dec 19, 2020
torch/quantization/fx/quantize.py
Outdated
| @@ -981,7 +985,7 @@ def visit_arg(arg): | |||
| # overwrite previous activation post process constructor if | |||
| # necessary | |||
| quants[arg.name] = ( | |||
| DefaultQuantizeHandler(self, arg), act_post_process_ctr) | |||
| DefaultQuantizeHandler(self, arg), act_post_process_ctr, is_weight) | |||
There was a problem hiding this comment.
I think we don't need is_weight, this info is used to decide act_post_process_ctr already in L976
There was a problem hiding this comment.
also we can remove L978-979 I think
jerryzh168
reviewed
Dec 19, 2020
jerryzh168
requested changes
Dec 19, 2020
Summary: Add types to `_find_quants` I/O and fix resulting errors, needed for an upcoming bug fix. Test Plan: ``` mypy torch/quantization python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25645719](https://our.internmc.facebook.com/intern/diff/D25645719) [ghstack-poisoned]
vkuzo
commented
Dec 19, 2020
| @@ -571,14 +574,9 @@ def load_non_quantized(n): | |||
| return env[n.name] | |||
|
|
|||
| def load_quantized(n): | |||
| if n.name not in quant_env: | |||
There was a problem hiding this comment.
this code was flagged unreachable, deleting
Summary: Add types to `_find_quants` I/O and fix resulting errors, needed for an upcoming bug fix. Test Plan: ``` mypy torch/quantization python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25645719](https://our.internmc.facebook.com/intern/diff/D25645719) [ghstack-poisoned]
separate PR, to keep things small? since this is really just annotating types and fixing bugs uncovered by that |
jerryzh168
approved these changes
Dec 19, 2020
Summary: Add types to `_find_quants` I/O and fix resulting errors, needed for an upcoming bug fix. Test Plan: ``` mypy torch/quantization python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25645719](https://our.internmc.facebook.com/intern/diff/D25645719) [ghstack-poisoned]
Summary: Add types to `_find_quants` I/O and fix resulting errors, needed for an upcoming bug fix. Test Plan: ``` mypy torch/quantization python test/test_quantization.py TestQuantizeFx ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25645719](https://our.internmc.facebook.com/intern/diff/D25645719) [ghstack-poisoned]
This was referenced Dec 21, 2020
|
This pull request has been merged in edce6b1. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49616 Add types to `_find_quants` I/O and fix resulting errors, needed for an upcoming bug fix. Test Plan: ``` mypy torch/quantization python test/test_quantization.py TestQuantizeFx ``` Imported from OSS Reviewed By: jerryzh168 Differential Revision: D25645719 fbshipit-source-id: 4bf788b55fd4fd086c83a4438b9c2df22b9cff49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Add types to
_find_quantsI/O and fix resulting errors,needed for an upcoming bug fix.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25645719