fx quant: add types to observed_module.py #49607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Readability Test Plan: ``` mypy torch/quantization ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Dec 18, 2020
💊 CI failures summary and remediationsAs of commit ee2d076 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 5 times. |
vkuzo
added a commit
that referenced
this pull request
Dec 18, 2020
Summary: Readability Test Plan: ``` mypy torch/quantization ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 5db79c0a63c1fe4722d99ceb1e0a0c2acbf2249f Pull Request resolved: #49607
jerryzh168
reviewed
Dec 18, 2020
| return ObservedGraphModule(module, module.graph) | ||
|
|
||
| def is_observed_module(module): | ||
| def is_observed_module(module: Any) -> bool: |
There was a problem hiding this comment.
can this be GraphModule as well?
jerryzh168
approved these changes
Dec 18, 2020
This was referenced Dec 18, 2020
Summary: Readability Test Plan: ``` mypy torch/quantization ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25643895](https://our.internmc.facebook.com/intern/diff/D25643895) [ghstack-poisoned]
This was referenced Dec 21, 2020
|
This pull request has been merged in 7c90b20. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49607 Readability Test Plan: ``` mypy torch/quantization ``` Imported from OSS Reviewed By: jerryzh168 Differential Revision: D25643895 fbshipit-source-id: b4b8741b07ac4827c3bacd2084df81fbfdd0c2d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Readability
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25643895