Skip to content

Conversation

wayi1
Copy link
Contributor

@wayi1 wayi1 commented Dec 21, 2020

Stack from ghstack:

Address the comment on #49417 (comment)

Differential Revision: D25673997

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 21, 2020

💊 CI failures summary and remediations

As of commit 62e1ee7 (more details on the Dr. CI page):


  • 3/4 failures possibly* introduced in this PR
    • 1/3 non-CircleCI failure(s)
  • 1/4 broken upstream at merge base b288aee on Dec 21 from 3:35pm to 9:32pm

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 62e1ee76dc Update on "[Gradient Compression] Directly let world_size = group_to_use.size()"
+ git reset --hard 62e1ee76dc8b95350ecdc5018b203efff2d78aa5
HEAD is now at 62e1ee76dc Update on "[Gradient Compression] Directly let world_size = group_to_use.size()"
+ git merge --allow-unrelated-histories --no-edit --no-ff 7b4a7661d6de659c8423015a2f3e93308eb83850
Auto-merging torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
CONFLICT (content): Merge conflict in torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 62e1ee76dc Update on "[Gradient Compression] Directly let world_size = group_to_use.size()"
+ git reset --hard 62e1ee76dc8b95350ecdc5018b203efff2d78aa5
HEAD is now at 62e1ee76dc Update on "[Gradient Compression] Directly let world_size = group_to_use.size()"
+ git merge --allow-unrelated-histories --no-edit --no-ff 7b4a7661d6de659c8423015a2f3e93308eb83850
Auto-merging torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
CONFLICT (content): Merge conflict in torch/distributed/algorithms/ddp_comm_hooks/powerSGD_hook.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1


1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 8 times.

@wayi1 wayi1 changed the title [Gradient Compression] Directly let world_size = process_group.size() [Gradient Compression] Directly let world_size = group_to_use.size() Dec 22, 2020
…use.size()"


Address the comment on #49417 (comment)

Differential Revision: [D25673997](https://our.internmc.facebook.com/intern/diff/D25673997/)

[ghstack-poisoned]
wayi1 pushed a commit that referenced this pull request Dec 22, 2020
Pull Request resolved: #49715

Address the comment on #49417 (comment)
ghstack-source-id: 119049598

Differential Revision: [D25673997](https://our.internmc.facebook.com/intern/diff/D25673997/)
@wayi1 wayi1 requested a review from rohan-varma December 22, 2020 18:52
Copy link
Contributor

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although might want to rebase since some CI looks like it failed with merge conflicts.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 55b431b.

@facebook-github-bot facebook-github-bot deleted the gh/SciPioneer/42/head branch December 26, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants