-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Gradient Compression] Directly let world_size = group_to_use.size() #49715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Address the comment on #49417 (comment) Differential Revision: [D25673997](https://our.internmc.facebook.com/intern/diff/D25673997/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 62e1ee7 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Address the comment on #49417 (comment) Differential Revision: [D25673997](https://our.internmc.facebook.com/intern/diff/D25673997/) ghstack-source-id: 119021459 Pull Request resolved: #49715
…use.size()" Address the comment on #49417 (comment) Differential Revision: [D25673997](https://our.internmc.facebook.com/intern/diff/D25673997/) [ghstack-poisoned]
Pull Request resolved: #49715 Address the comment on #49417 (comment) ghstack-source-id: 119049598 Differential Revision: [D25673997](https://our.internmc.facebook.com/intern/diff/D25673997/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although might want to rebase since some CI looks like it failed with merge conflicts.
This pull request has been merged in 55b431b. |
Stack from ghstack:
Address the comment on #49417 (comment)
Differential Revision: D25673997