Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Fix bug in unfold symbolic #50504

Merged
merged 2 commits into from Jan 29, 2021
Merged

Conversation

KsenijaS
Copy link
Contributor

Fix bug in unfold symbolic

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 13, 2021

💊 CI failures summary and remediations

As of commit 3ba0370 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please rebase to udpated onnx_ms_1 branch

Copy link
Contributor

@jiafatom jiafatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

.jenkins/caffe2/test.sh Outdated Show resolved Hide resolved
@KsenijaS KsenijaS reopened this Jan 28, 2021
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #50504 (3ba0370) into onnx_ms_1 (cc211bb) will decrease coverage by 0.34%.
The diff coverage is 55.55%.

@@              Coverage Diff              @@
##           onnx_ms_1   #50504      +/-   ##
=============================================
- Coverage      80.85%   80.50%   -0.35%     
=============================================
  Files           1931     1931              
  Lines         210932   210937       +5     
=============================================
- Hits          170542   169822     -720     
- Misses         40390    41115     +725     

BowenBao added a commit that referenced this pull request Feb 2, 2021
Fix bug in unfold symbolic

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Feb 3, 2021
Fix bug in unfold symbolic

Differential Revision: [D26203113](https://our.internmc.facebook.com/intern/diff/D26203113)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Feb 4, 2021
Summary:
Pull Request resolved: #51515

Fix bug in unfold symbolic

Test Plan: Imported from OSS

Reviewed By: pbelevich

Differential Revision: D26203113

Pulled By: SplitInfinity

fbshipit-source-id: 3a1b0013624d918de762a88ac6de8c9cafa0f732
BowenBao added a commit to BowenBao/pytorch that referenced this pull request Feb 5, 2021
Fix bug in unfold symbolic

ghstack-source-id: 51f0c4d4aff14a82f225f79e2b704b3d56e158a8
Pull Request resolved: pytorch#51515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants