Skip to content

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Feb 2, 2021

Stack from ghstack:

Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

Differential Revision: D26203116

Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Feb 2, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 2, 2021

💊 CI failures summary and remediations

As of commit bf5045f (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 03 23:47:33 RuntimeError: CUDA error: an illegal memory access was encountered
Feb 03 23:47:33   File "test_optim.py", line 1994, in test_update_bn_dnn
Feb 03 23:47:33     self._test_update_bn(dnn.cuda(), dl_x, dl_xy, True)
Feb 03 23:47:33   File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in cuda
Feb 03 23:47:33     return self._apply(lambda t: t.cuda(device))
Feb 03 23:47:33   File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 387, in _apply
Feb 03 23:47:33     module._apply(fn)
Feb 03 23:47:33   File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 409, in _apply
Feb 03 23:47:33     param_applied = fn(param)
Feb 03 23:47:33   File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in <lambda>
Feb 03 23:47:33     return self._apply(lambda t: t.cuda(device))
Feb 03 23:47:33 RuntimeError: CUDA error: an illegal memory access was encountered
Feb 03 23:47:33 
Feb 03 23:47:33 ----------------------------------------------------------------------
Feb 03 23:47:33 Ran 104 tests in 37.815s
Feb 03 23:47:33 
Feb 03 23:47:33 FAILED (errors=13)
Feb 03 23:47:33 
Feb 03 23:47:33 Generating XML reports...
Feb 03 23:47:33 Generated XML report: test-reports/dist-gloo/TEST-TestLRScheduler-20210203234655.xml
Feb 03 23:47:33 Generated XML report: test-reports/dist-gloo/TEST-TestOptim-20210203234655.xml
Feb 03 23:47:33 Generated XML report: test-reports/dist-gloo/TEST-TestSWAUtils-20210203234655.xml

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

[ghstack-poisoned]
Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

Differential Revision: [D26203116](https://our.internmc.facebook.com/intern/diff/D26203116)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in 3f185ac.

BowenBao added a commit to BowenBao/pytorch that referenced this pull request Feb 5, 2021
Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

ghstack-source-id: 6ed0172
Pull Request resolved: pytorch#51517
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/14/head branch February 8, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants