Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Update unsafe_chunk() method to support new version 13 of Split operator. (#51415) #51524

Closed
wants to merge 3 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Feb 2, 2021

Stack from ghstack:

Co-authored-by: Negin Raoof neginmr@utexas.edu

Differential Revision: D26203123

…t operator. (#51415)

* def unsafe_chunk() support and test in ops13.

* Use _unsqueeze_helper insteadof Unsqueeze operator

* Cast the splits into long.

* Change the test to a fixed dimension.

* Update test_pytorch_onnx_onnxruntime.py

* Disable test_loop_with_list for opset 13.

Co-authored-by: Negin Raoof <neginmr@utexas.edu>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 2, 2021

💊 CI failures summary and remediations

As of commit 4f88277 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 03 23:47:23 RuntimeError: CUDA error: an illegal memory access was encountered
Feb 03 23:47:23   File "test_optim.py", line 1994, in test_update_bn_dnn
Feb 03 23:47:23     self._test_update_bn(dnn.cuda(), dl_x, dl_xy, True)
Feb 03 23:47:23   File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in cuda
Feb 03 23:47:23     return self._apply(lambda t: t.cuda(device))
Feb 03 23:47:23   File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 387, in _apply
Feb 03 23:47:23     module._apply(fn)
Feb 03 23:47:23   File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 409, in _apply
Feb 03 23:47:23     param_applied = fn(param)
Feb 03 23:47:23   File "/opt/conda/lib/python3.6/site-packages/torch/nn/modules/module.py", line 491, in <lambda>
Feb 03 23:47:23     return self._apply(lambda t: t.cuda(device))
Feb 03 23:47:23 RuntimeError: CUDA error: an illegal memory access was encountered
Feb 03 23:47:23 
Feb 03 23:47:23 ----------------------------------------------------------------------
Feb 03 23:47:23 Ran 104 tests in 39.229s
Feb 03 23:47:23 
Feb 03 23:47:23 FAILED (errors=13)
Feb 03 23:47:23 
Feb 03 23:47:23 Generating XML reports...
Feb 03 23:47:23 Generated XML report: test-reports/dist-gloo/TEST-TestLRScheduler-20210203234644.xml
Feb 03 23:47:23 Generated XML report: test-reports/dist-gloo/TEST-TestOptim-20210203234644.xml
Feb 03 23:47:23 Generated XML report: test-reports/dist-gloo/TEST-TestSWAUtils-20210203234644.xml

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

BowenBao added a commit that referenced this pull request Feb 2, 2021
…t operator. (#51415)

* def unsafe_chunk() support and test in ops13.

* Use _unsqueeze_helper insteadof Unsqueeze operator

* Cast the splits into long.

* Change the test to a fixed dimension.

* Update test_pytorch_onnx_onnxruntime.py

* Disable test_loop_with_list for opset 13.

Co-authored-by: Negin Raoof <neginmr@utexas.edu>

ghstack-source-id: 5ef427236841a07e6abaf85a89975d3a16808659
Pull Request resolved: #51524
… 13 of Split operator. (#51415)"

* def unsafe_chunk() support and test in ops13.

* Use _unsqueeze_helper insteadof Unsqueeze operator

* Cast the splits into long.

* Change the test to a fixed dimension.

* Update test_pytorch_onnx_onnxruntime.py

* Disable test_loop_with_list for opset 13.

Co-authored-by: Negin Raoof <neginmr@utexas.edu>

[ghstack-poisoned]
… 13 of Split operator. (#51415)"

* def unsafe_chunk() support and test in ops13.

* Use _unsqueeze_helper insteadof Unsqueeze operator

* Cast the splits into long.

* Change the test to a fixed dimension.

* Update test_pytorch_onnx_onnxruntime.py

* Disable test_loop_with_list for opset 13.

Co-authored-by: Negin Raoof <neginmr@utexas.edu>

Differential Revision: [D26203123](https://our.internmc.facebook.com/intern/diff/D26203123)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in ba824eb.

BowenBao added a commit to BowenBao/pytorch that referenced this pull request Feb 5, 2021
…t operator. (pytorch#51415)

* def unsafe_chunk() support and test in ops13.

* Use _unsqueeze_helper insteadof Unsqueeze operator

* Cast the splits into long.

* Change the test to a fixed dimension.

* Update test_pytorch_onnx_onnxruntime.py

* Disable test_loop_with_list for opset 13.

Co-authored-by: Negin Raoof <neginmr@utexas.edu>

ghstack-source-id: 9b8b4b15bf081420d73995396642393a8f16464a
Pull Request resolved: pytorch#51524
@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/21/head branch February 8, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants