[ONNX] Update constant-folding of Gather op #50554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
cla signed
oncall: jit
neginraoof
reviewed
Jan 27, 2021
jiafatom
reviewed
Jan 28, 2021
jiafatom
approved these changes
Jan 28, 2021
Codecov Report
@@ Coverage Diff @@
## onnx_ms_1 #50554 +/- ##
=============================================
- Coverage 80.85% 80.84% -0.01%
=============================================
Files 1931 1931
Lines 210932 210959 +27
=============================================
+ Hits 170542 170560 +18
- Misses 40390 40399 +9 |
BowenBao
added a commit
that referenced
this pull request
Feb 2, 2021
Update constant-folding of Gather operator so it also includes cases where rank of indices input is 0. Currently it only support cases where rank of indices is 1. [ghstack-poisoned]
This was referenced Feb 2, 2021
This was referenced Feb 2, 2021
Closed
Closed
BowenBao
added a commit
that referenced
this pull request
Feb 2, 2021
Update constant-folding of Gather operator so it also includes cases where rank of indices input is 0. Currently it only support cases where rank of indices is 1. Differential Revision: [D26191323](https://our.internmc.facebook.com/intern/diff/D26191323) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Feb 3, 2021
Update constant-folding of Gather operator so it also includes cases where rank of indices input is 0. Currently it only support cases where rank of indices is 1. Differential Revision: [D26191323](https://our.internmc.facebook.com/intern/diff/D26191323) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 4, 2021
Summary: Pull Request resolved: #51514 Update constant-folding of Gather operator so it also includes cases where rank of indices input is 0. Currently it only support cases where rank of indices is 1. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D26191323 Pulled By: SplitInfinity fbshipit-source-id: 7edcbd8835b0248fefb908aca394f5cca5eae29e
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 5, 2021
Update constant-folding of Gather operator so it also includes cases where rank of indices input is 0. Currently it only support cases where rank of indices is 1. ghstack-source-id: 3752c5ada1735d17b6b785cc274b9169145e94e5 Pull Request resolved: pytorch#51514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update constant-folding of Gather operator so it also includes cases where rank of indices input is 0.
Currently it only support cases where rank of indices is 1.