New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Export get/set attribute nodes #50768
Merged
BowenBao
merged 8 commits into
pytorch:onnx_ms_1
from
neginraoof:neraoof/fixSetAttribute
Jan 29, 2021
Merged
[ONNX] Export get/set attribute nodes #50768
BowenBao
merged 8 commits into
pytorch:onnx_ms_1
from
neginraoof:neraoof/fixSetAttribute
Jan 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
cla signed
oncall: jit
Add this issue/PR to JIT oncall triage queue
labels
Jan 19, 2021
BowenBao
reviewed
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great progress on the support for inplace ops! Leaving comments while reading through the code ..
neginraoof
force-pushed
the
neraoof/fixSetAttribute
branch
from
January 28, 2021 19:35
fa152b3
to
cc211bb
Compare
BowenBao
reviewed
Jan 28, 2021
BowenBao
reviewed
Jan 28, 2021
BowenBao
reviewed
Jan 28, 2021
BowenBao
reviewed
Jan 28, 2021
…ch into neraoof/fixSetAttribute
BowenBao
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
BowenBao
added a commit
that referenced
this pull request
Feb 2, 2021
Fix get/set attributes when getting/setting a model parameter. This PR also fixes inplace ops in If blocks. [ghstack-poisoned]
This was referenced Feb 2, 2021
This was referenced Feb 2, 2021
Closed
Closed
BowenBao
added a commit
that referenced
this pull request
Feb 2, 2021
Fix get/set attributes when getting/setting a model parameter. This PR also fixes inplace ops in If blocks. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Feb 3, 2021
Fix get/set attributes when getting/setting a model parameter. This PR also fixes inplace ops in If blocks. Differential Revision: [D26203116](https://our.internmc.facebook.com/intern/diff/D26203116) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 4, 2021
Summary: Pull Request resolved: #51517 Fix get/set attributes when getting/setting a model parameter. This PR also fixes inplace ops in If blocks. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D26203116 Pulled By: SplitInfinity fbshipit-source-id: bed6ee6dd92b5b43febc8c584a6872290f8fe33f
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 5, 2021
Fix get/set attributes when getting/setting a model parameter. This PR also fixes inplace ops in If blocks. ghstack-source-id: 6ed01725c9ea350544853498ddef7c0d8641ccae Pull Request resolved: pytorch#51517
jiafatom
pushed a commit
to jiafatom/pytorch
that referenced
this pull request
Feb 26, 2021
Fix get/set attributes when getting/setting a model parameter. This PR also fixes inplace ops in If blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.