Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Export get/set attribute nodes #50768

Merged
merged 8 commits into from Jan 29, 2021

Conversation

neginraoof
Copy link
Contributor

Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great progress on the support for inplace ops! Leaving comments while reading through the code ..

@neginraoof neginraoof reopened this Jan 28, 2021
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BowenBao BowenBao merged commit 4fab460 into pytorch:onnx_ms_1 Jan 29, 2021
BowenBao added a commit that referenced this pull request Feb 2, 2021
Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Feb 2, 2021
Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

[ghstack-poisoned]
BowenBao added a commit that referenced this pull request Feb 3, 2021
Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

Differential Revision: [D26203116](https://our.internmc.facebook.com/intern/diff/D26203116)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Feb 4, 2021
Summary:
Pull Request resolved: #51517

Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

Test Plan: Imported from OSS

Reviewed By: pbelevich

Differential Revision: D26203116

Pulled By: SplitInfinity

fbshipit-source-id: bed6ee6dd92b5b43febc8c584a6872290f8fe33f
BowenBao added a commit to BowenBao/pytorch that referenced this pull request Feb 5, 2021
Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.

ghstack-source-id: 6ed01725c9ea350544853498ddef7c0d8641ccae
Pull Request resolved: pytorch#51517
jiafatom pushed a commit to jiafatom/pytorch that referenced this pull request Feb 26, 2021
Fix get/set attributes when getting/setting a model parameter.
This PR also fixes inplace ops in If blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed oncall: jit Add this issue/PR to JIT oncall triage queue open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants