[ONNX] Enable remaining failed tests in opset13 #50806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hwangdeyu
commented
Jan 20, 2021
hwangdeyu
commented
- The reason of the most test failures in opset 13 is the "where" op uses the "unbind" and "split" old op version, which will throw the split error.
- Other tests can be passed after the updated of Squeeze and Unsqueeze.
hwangdeyu
changed the title
neginraoof
reviewed
Jan 20, 2021
hwangdeyu
force-pushed
the
deyu/enable_opset13_missingtest
branch
3 times, most recently
from
9aa8332
to
97bdbd1
Compare
neginraoof
reviewed
Jan 22, 2021
hwangdeyu
force-pushed
the
deyu/enable_opset13_missingtest
branch
from
712334b
to
89f3739
Compare
|
Please rebase this before merge. |
hwangdeyu
force-pushed
the
deyu/enable_opset13_missingtest
branch
from
050b804
to
c66b81d
Compare
BowenBao
added a commit
that referenced
this pull request
Feb 2, 2021
* enable remaining test in opset13 * add comments for error version test info * fix comments:opset12 unbind problem * add ignore[no-redef] * fix format Co-authored-by: hwangdeyu <deyhuang@qq.com> [ghstack-poisoned]
This was referenced Feb 2, 2021
This was referenced Feb 2, 2021
Closed
Closed
BowenBao
added a commit
that referenced
this pull request
Feb 2, 2021
* enable remaining test in opset13 * add comments for error version test info * fix comments:opset12 unbind problem * add ignore[no-redef] * fix format Co-authored-by: hwangdeyu <deyhuang@qq.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Feb 3, 2021
* enable remaining test in opset13 * add comments for error version test info * fix comments:opset12 unbind problem * add ignore[no-redef] * fix format Co-authored-by: hwangdeyu <deyhuang@qq.com> Differential Revision: [D26203122](https://our.internmc.facebook.com/intern/diff/D26203122) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 4, 2021
Summary: Pull Request resolved: #51518 * enable remaining test in opset13 * add comments for error version test info * fix comments:opset12 unbind problem * add ignore[no-redef] * fix format Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D26203122 Pulled By: SplitInfinity fbshipit-source-id: e7d95bd2ce13f79f11965be82f640379cd55ff0f Co-authored-by: hwangdeyu <deyhuang@qq.com>
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 5, 2021
* enable remaining test in opset13 * add comments for error version test info * fix comments:opset12 unbind problem * add ignore[no-redef] * fix format Co-authored-by: hwangdeyu <deyhuang@qq.com> ghstack-source-id: 4ea81e90c66678d953b5219b9672444eedde62f3 Pull Request resolved: pytorch#51518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.