Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Fix opset 11 ConstantChunk with negative dim #51396

Merged
merged 4 commits into from Feb 2, 2021

Conversation

BowenBao
Copy link
Collaborator

No description provided.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 30, 2021

💊 CI failures summary and remediations

As of commit 6be1604 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 01 23:17:52 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.
Feb 01 23:17:52 processing existing schema:  alltoall(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, Tensor[] _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
Feb 01 23:17:52 processing existing schema:  send(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
Feb 01 23:17:52 processing existing schema:  recv(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
Feb 01 23:17:52 processing existing schema:  recv_anysource(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
Feb 01 23:17:52 processing existing schema:  barrier(__torch__.torch.classes.dist_c10d.ProcessGroup _0) -> (__torch__.torch.classes.dist_c10d.Work _0)
Feb 01 23:17:52 processing existing schema:  __init__(__torch__.torch.classes.dist_c10d.frontend _0) -> (None _0)
Feb 01 23:17:52 processing existing schema:  new_process_group_helper(__torch__.torch.classes.dist_c10d.frontend _0, int _1, int _2, int[] _3, str _4, __torch__.torch.classes.dist_c10d.Store _5, str? _6, int _7) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
Feb 01 23:17:52 processing existing schema:  get_process_group_by_name(__torch__.torch.classes.dist_c10d.frontend _0, str _1) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
Feb 01 23:17:52 processing existing schema:  get_name_of_process_group(__torch__.torch.classes.dist_c10d.frontend _0, __torch__.torch.classes.dist_c10d.ProcessGroup _1) -> (str _0)
Feb 01 23:17:52 processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (None _0)
Feb 01 23:17:52 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
Feb 01 23:17:52 
Feb 01 23:17:52 Broken ops: [
Feb 01 23:17:52 	aten::fake_quantize_per_channel_affine_cachemask_backward(Tensor grad, Tensor mask) -> (Tensor)
Feb 01 23:17:52 	aten::_rowwise_prune(Tensor weight, Tensor mask, int compressed_indices_dtype) -> (Tensor, Tensor)
Feb 01 23:17:52 	aten::fake_quantize_per_channel_affine_cachemask(Tensor self, Tensor scale, Tensor zero_point, int axis, int quant_min, int quant_max) -> (Tensor output, Tensor mask)
Feb 01 23:17:52 ]
Feb 01 23:17:52 + cleanup
Feb 01 23:17:52 + retcode=1
Feb 01 23:17:52 + set +x
Feb 01 23:17:52 =================== sccache compilation log ===================

See CircleCI build pytorch_python_doc_build (2/2)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun)

Feb 01 23:30:36 Makefile:38: recipe for target 'html' failed
Feb 01 23:30:35 
Feb 01 23:30:35 copying static files... ... done
Feb 01 23:30:35 copying extra files... done
Feb 01 23:30:36 dumping search index in English (code: en)... done
Feb 01 23:30:36 dumping object inventory... done
Feb 01 23:30:36 build finished with problems, 1 warning.
Feb 01 23:30:36 /var/lib/jenkins/workspace/docs/src/pytorch-sphinx-theme/pytorch_sphinx_theme/search.html:21: RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead.
Feb 01 23:30:36   <p class="last">
Feb 01 23:30:36 /var/lib/jenkins/workspace/docs/src/pytorch-sphinx-theme/pytorch_sphinx_theme/search.html:24: RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead.
Feb 01 23:30:36   </p>
Feb 01 23:30:36 Makefile:38: recipe for target 'html' failed
Feb 01 23:30:36 make: *** [html] Error 1
Feb 01 23:30:36 ++ code=2
Feb 01 23:30:36 ++ '[' 2 -ne 0 ']'
Feb 01 23:30:36 ++ set +x
Feb 01 23:30:36 =========================
Feb 01 23:30:36 /var/lib/jenkins/workspace/docs/source/notes/broadcasting.rst:6: WARNING: 'any' reference target not found: numpy.doc.broadcasting
Feb 01 23:30:36 =========================
Feb 01 23:30:36 Docs build failed. If the failure is not clear, scan back in the log
Feb 01 23:30:36 for any WARNINGS or for the line build finished with problems
Feb 01 23:30:36 (tried to echo the WARNINGS above the ==== line)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@@ -5823,6 +5830,22 @@ def make_input(batch_size):
other_input = make_input(RNN_BATCH_SIZE + 1)
self.run_test(model, other_input, batch_size=RNN_BATCH_SIZE + 1)

@disableScriptTest()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment why we are disabling scripting test for this one will be nice.

Copy link

@spandantiwari spandantiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@BowenBao BowenBao merged commit f15d3f4 into pytorch:onnx_ms_1 Feb 2, 2021
BowenBao added a commit that referenced this pull request Feb 2, 2021
BowenBao added a commit that referenced this pull request Feb 2, 2021
ghstack-source-id: e50ed94c2f7b061cbfb2e022f16062080c5c26e7
Pull Request resolved: #51525
BowenBao added a commit that referenced this pull request Feb 2, 2021
BowenBao added a commit that referenced this pull request Feb 3, 2021
facebook-github-bot pushed a commit that referenced this pull request Feb 4, 2021
Summary: Pull Request resolved: #51525

Test Plan: Imported from OSS

Reviewed By: pbelevich

Differential Revision: D26203115

Pulled By: SplitInfinity

fbshipit-source-id: d76942f7cc5812c8a1cc16891e4956cc658283d8
BowenBao added a commit to BowenBao/pytorch that referenced this pull request Feb 5, 2021
ghstack-source-id: b5afbe84c2d24348ad4ea4b1defb23172f5a156e
Pull Request resolved: pytorch#51525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants