upsample_bilinear2d and upsample_bicubic2d: port to structured
#52012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Feb 10, 2021
💊 CI failures summary and remediationsAs of commit dfaa5ab (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…red" Differential Revision: [D26356329](https://our.internmc.facebook.com/intern/diff/D26356329) [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Feb 10, 2021
ghstack-source-id: 4dc26276076057761fbf3c74f7cb7642fa638259 Pull Request resolved: #52012
ezyang
approved these changes
Feb 10, 2021
…red" Going ahead and porting the other upsample ops to structured since they follow a similar pattern. Differential Revision: [D26356329](https://our.internmc.facebook.com/intern/diff/D26356329) [ghstack-poisoned]
…red" Going ahead and porting the other upsample ops to structured since they follow a similar pattern. Differential Revision: [D26356329](https://our.internmc.facebook.com/intern/diff/D26356329) [ghstack-poisoned]
…red" Going ahead and porting the other upsample ops to structured since they follow a similar pattern. Differential Revision: [D26356329](https://our.internmc.facebook.com/intern/diff/D26356329) [ghstack-poisoned]
…red" Going ahead and porting the other upsample ops to structured since they follow a similar pattern. Differential Revision: [D26356329](https://our.internmc.facebook.com/intern/diff/D26356329) [ghstack-poisoned]
…red" Going ahead and porting the other upsample ops to structured since they follow a similar pattern. Differential Revision: [D26356329](https://our.internmc.facebook.com/intern/diff/D26356329) [ghstack-poisoned]
…red" Going ahead and porting the other upsample ops to structured since they follow a similar pattern. Differential Revision: [D26356329](https://our.internmc.facebook.com/intern/diff/D26356329) [ghstack-poisoned]
…red" Going ahead and porting the other upsample ops to structured since they follow a similar pattern. Differential Revision: [D26356329](https://our.internmc.facebook.com/intern/diff/D26356329) [ghstack-poisoned]
…red" Going ahead and porting the other upsample ops to structured since they follow a similar pattern. Differential Revision: [D26356329](https://our.internmc.facebook.com/intern/diff/D26356329) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/bdhirsh/78/base #52012 +/- ##
===================================================
Coverage 80.76% 80.76%
===================================================
Files 1969 1969
Lines 216005 215958 -47
===================================================
- Hits 174454 174417 -37
+ Misses 41551 41541 -10 |
fmassa
reviewed
Mar 8, 2021
| output_height, | ||
| output_width); | ||
|
|
||
| output.resize_({nbatch, channels, output_height, output_width}, input.suggest_memory_format()); |
There was a problem hiding this comment.
Looks like we don't suggest memory_format here either, the same as in https://github.com/pytorch/pytorch/pull/52065/files#r589557711
cc @vfdev-5
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
…h#52012) Summary: Pull Request resolved: pytorch#52012 Test Plan: Imported from OSS Reviewed By: ezyang Differential Revision: D26356329 Pulled By: bdhirsh fbshipit-source-id: 8f974224799493e3172fe5dff3fbd43af8c09722
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…h#52012) Summary: Pull Request resolved: pytorch#52012 Test Plan: Imported from OSS Reviewed By: ezyang Differential Revision: D26356329 Pulled By: bdhirsh fbshipit-source-id: 8f974224799493e3172fe5dff3fbd43af8c09722
bdhirsh
changed the title
upsample_bilinear2d and upsample_bicubic2d: port to structured (#52012)
bdhirsh
changed the title
upsample_bilinear2d and upsample_bicubic2d: port to structured (#52012)upsample_bilinear2d and upsample_bicubic2d: port to structured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going ahead and porting the other upsample ops to structured since they follow a similar pattern.
Stack from ghstack:
upsample_nearest3dandupsample_trilinear3d: port to structured #52065 port upsample_nearest3d and upsample_trilinear3d to structuredupsample_bilinear2dandupsample_bicubic2d: port to structured #52012 port upsample_bilinear2d and upsample_bicubic2d to structuredupsample_linear1d: port to structured #51917 port upsample_linear1d to structuredDifferential Revision: D26356329