upsample_linear1d: port to structured
#51917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit cad2e7b (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Porting `upsample_linear1d` to structured. The shape checking logic is identical between `upsample_linear1d` and `upsample_nearest1d`, so I moved it to `UpSample.h`. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases. Differential Revision: [D26327750](https://our.internmc.facebook.com/intern/diff/D26327750) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/bdhirsh/75/base #51917 +/- ##
===================================================
Coverage 80.76% 80.76%
===================================================
Files 1969 1969
Lines 216037 216005 -32
===================================================
- Hits 174476 174454 -22
+ Misses 41561 41551 -10 |
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: Pull Request resolved: pytorch#51917 Test Plan: Imported from OSS Reviewed By: ezyang Differential Revision: D26327750 Pulled By: bdhirsh fbshipit-source-id: 443ad278010ce655eb5f08fa6889c45ccb328268
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#51917 Test Plan: Imported from OSS Reviewed By: ezyang Differential Revision: D26327750 Pulled By: bdhirsh fbshipit-source-id: 443ad278010ce655eb5f08fa6889c45ccb328268
bdhirsh
changed the title
bdhirsh
changed the title
upsample_linear1d: port to structured (#51917)
bdhirsh
changed the title
upsample_linear1d: port to structured (#51917)upsample_linear1d: port to structured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting
upsample_linear1dto structured.The shape checking logic is identical between
upsample_linear1dandupsample_nearest1d, so I moved it toUpSample.h. We actually already had a function that did something similar, but it also tried to account for differences in shape checking between the forward and backward kernels- I opted instead to let the individual kernels handle those specific cases.Stack from ghstack:
upsample_nearest3dandupsample_trilinear3d: port to structured #52065 port upsample_nearest3d and upsample_trilinear3d to structuredupsample_bilinear2dandupsample_bicubic2d: port to structured #52012 port upsample_bilinear2d and upsample_bicubic2d to structuredupsample_linear1d: port to structured #51917 port upsample_linear1d to structuredDifferential Revision: D26327750