Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added OpInfo gradcheck_wrapper to replace output_func #54914

Closed
wants to merge 2 commits into from
Closed

Added OpInfo gradcheck_wrapper to replace output_func #54914

wants to merge 2 commits into from

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Mar 29, 2021 •
edited

Added a field to OpInfo to provide a wrapper function for gradcheck. This is useful for functions that need to perform some extra input/output processing to work with gradcheck.

fixes #50837

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 29, 2021 •
edited

💊 CI failures summary and remediations

As of commit e8d36c8 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@mruberry
Copy link
Collaborator

This is cool. @IvanYashchuk, would you like to take a look?

@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited

Codecov Report

Merging #54914 (e8d36c8) into master (449a951) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #54914      +/-   ##
==========================================
+ Coverage   76.75%   77.23%   +0.48%     
==========================================
  Files        1893     1893              
  Lines      186433   186459      +26     
==========================================
+ Hits       143099   144016     +917     
+ Misses      43334    42443     -891

IvanYashchuk
IvanYashchuk approved these changes Mar 30, 2021
View reviewed changes
Copy link
Collaborator

@IvanYashchuk IvanYashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@heitorschueroff heitorschueroff changed the title Added OpInfo gradcheck wrapper grad_func to replace output_func Added OpInfo gradcheck_wrapper to replace output_func Mar 30, 2021
@heitorschueroff heitorschueroff mentioned this pull request Mar 30, 2021
Closed
mruberry
mruberry approved these changes Mar 30, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Better get this landed ASAP!

@facebook-github-bot
Copy link
Contributor

@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@heitorschueroff heitorschueroff deleted the heitorschueroff/opinfo branch March 31, 2021 15:05
@heitorschueroff heitorschueroff restored the heitorschueroff/opinfo branch March 31, 2021 15:11
@facebook-github-bot
Copy link
Contributor

@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in 8b8c409.

@heitorschueroff heitorschueroff deleted the heitorschueroff/opinfo branch April 6, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanYashchuk IvanYashchuk IvanYashchuk approved these changes

@mruberry mruberry mruberry approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add op.input_func to OpInfo-based testing
4 participants
@heitorschueroff @facebook-github-bot @mruberry @IvanYashchuk