-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OpInfo gradcheck_wrapper to replace output_func #54914
Conversation
💊 CI failures summary and remediationsAs of commit e8d36c8 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This is cool. @IvanYashchuk, would you like to take a look? |
887db32
to
540064e
Compare
Codecov Report
@@ Coverage Diff @@
## master #54914 +/- ##
==========================================
+ Coverage 76.75% 77.23% +0.48%
==========================================
Files 1893 1893
Lines 186433 186459 +26
==========================================
+ Hits 143099 144016 +917
+ Misses 43334 42443 -891 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Better get this landed ASAP!
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1421744
to
fea54d1
Compare
fea54d1
to
e8d36c8
Compare
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@heitorschueroff merged this pull request in 8b8c409. |
Added a field to
OpInfo
to provide a wrapper function for gradcheck. This is useful for functions that need to perform some extra input/output processing to work with gradcheck.fixes #50837