[ONNX] Improve index_put symbolic to handle singular Bool updates #53690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit c3a300b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
I can confirm this solves the issue in #53507 |
jiafatom
reviewed
Mar 10, 2021
jiafatom
reviewed
Mar 10, 2021
jiafatom
approved these changes
Mar 10, 2021
shubhambhokare1
force-pushed
the
sbhokare/single_index_put
branch
from
808d507
to
c3a300b
Compare
Codecov Report
@@ Coverage Diff @@
## onnx_ms_1 #53690 +/- ##
=============================================
- Coverage 77.34% 77.34% -0.01%
=============================================
Files 1887 1887
Lines 184830 184833 +3
=============================================
- Hits 142956 142954 -2
- Misses 41874 41879 +5 |
This was referenced Mar 29, 2021
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 1, 2021
…3690) (#54863) Summary: Pull Request resolved: #54863 Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes #53507 Test Plan: Imported from OSS Reviewed By: nikithamalgifb Differential Revision: D27408977 Pulled By: SplitInfinity fbshipit-source-id: bcfb55b50ce76b3d4913ffbc16cdef1f98cb7a84
neginraoof
added a commit
that referenced
this pull request
Apr 6, 2021
* [ONNX] Improve index_put symbolic to handle singular Bool updates (#53690) Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes #53507 * [ONNX] Support primitive type input/outputs and attributes (#53550) Support primitive type attributes. Needed for Silero model. * [ONNX] Fix if output shape mismatch error & Fix graph input directly used as output (#53219) Fix if output shape mismatch error & Fix graph input directly used as output * Add support for hann_window operator. * [ONNX] Replace decomposeLinear pre process pass with a symbolic (#53077) Replace decomposeLinear pre process pass with a symbolic * Add a test case for dtype is None. * Resolve flake8 issue. * Remove one unused test case. * Add support for hann_window operator. * Add a test case for dtype is None. * Remove one unused test case. Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Negin Raoof <neginmr@utexas.edu> Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: Ksenija Stanojevic <KsenijaS@users.noreply.github.com>
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Apr 15, 2021
* [ONNX] Improve index_put symbolic to handle singular Bool updates (pytorch#53690) Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes pytorch#53507 * [ONNX] Support primitive type input/outputs and attributes (pytorch#53550) Support primitive type attributes. Needed for Silero model. * [ONNX] Fix if output shape mismatch error & Fix graph input directly used as output (pytorch#53219) Fix if output shape mismatch error & Fix graph input directly used as output * Add support for hann_window operator. * [ONNX] Replace decomposeLinear pre process pass with a symbolic (pytorch#53077) Replace decomposeLinear pre process pass with a symbolic * Add a test case for dtype is None. * Resolve flake8 issue. * Remove one unused test case. * Add support for hann_window operator. * Add a test case for dtype is None. * Remove one unused test case. Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Negin Raoof <neginmr@utexas.edu> Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: Ksenija Stanojevic <KsenijaS@users.noreply.github.com>
BowenBao
pushed a commit
that referenced
this pull request
Apr 15, 2021
* [ONNX] Improve index_put symbolic to handle singular Bool updates (#53690) Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes #53507 * [ONNX] Support primitive type input/outputs and attributes (#53550) Support primitive type attributes. Needed for Silero model. * [ONNX] Fix if output shape mismatch error & Fix graph input directly used as output (#53219) Fix if output shape mismatch error & Fix graph input directly used as output * Add support for hann_window operator. * [ONNX] Replace decomposeLinear pre process pass with a symbolic (#53077) Replace decomposeLinear pre process pass with a symbolic * Add a test case for dtype is None. * Resolve flake8 issue. * Remove one unused test case. * Add support for hann_window operator. * Add a test case for dtype is None. * Remove one unused test case. Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Negin Raoof <neginmr@utexas.edu> Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: Ksenija Stanojevic <KsenijaS@users.noreply.github.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 15, 2021
* [ONNX] Improve index_put symbolic to handle singular Bool updates (#53690) Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes #53507 * [ONNX] Support primitive type input/outputs and attributes (#53550) Support primitive type attributes. Needed for Silero model. * [ONNX] Fix if output shape mismatch error & Fix graph input directly used as output (#53219) Fix if output shape mismatch error & Fix graph input directly used as output * Add support for hann_window operator. * [ONNX] Replace decomposeLinear pre process pass with a symbolic (#53077) Replace decomposeLinear pre process pass with a symbolic * Add a test case for dtype is None. * Resolve flake8 issue. * Remove one unused test case. * Add support for hann_window operator. * Add a test case for dtype is None. * Remove one unused test case. Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Negin Raoof <neginmr@utexas.edu> Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: Ksenija Stanojevic <KsenijaS@users.noreply.github.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 16, 2021
* [ONNX] Improve index_put symbolic to handle singular Bool updates (#53690) Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes #53507 * [ONNX] Support primitive type input/outputs and attributes (#53550) Support primitive type attributes. Needed for Silero model. * [ONNX] Fix if output shape mismatch error & Fix graph input directly used as output (#53219) Fix if output shape mismatch error & Fix graph input directly used as output * Add support for hann_window operator. * [ONNX] Replace decomposeLinear pre process pass with a symbolic (#53077) Replace decomposeLinear pre process pass with a symbolic * Add a test case for dtype is None. * Resolve flake8 issue. * Remove one unused test case. * Add support for hann_window operator. * Add a test case for dtype is None. * Remove one unused test case. Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Negin Raoof <neginmr@utexas.edu> Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: Ksenija Stanojevic <KsenijaS@users.noreply.github.com> [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Apr 16, 2021
* [ONNX] Improve index_put symbolic to handle singular Bool updates (#53690) Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes #53507 * [ONNX] Support primitive type input/outputs and attributes (#53550) Support primitive type attributes. Needed for Silero model. * [ONNX] Fix if output shape mismatch error & Fix graph input directly used as output (#53219) Fix if output shape mismatch error & Fix graph input directly used as output * Add support for hann_window operator. * [ONNX] Replace decomposeLinear pre process pass with a symbolic (#53077) Replace decomposeLinear pre process pass with a symbolic * Add a test case for dtype is None. * Resolve flake8 issue. * Remove one unused test case. * Add support for hann_window operator. * Add a test case for dtype is None. * Remove one unused test case. Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Negin Raoof <neginmr@utexas.edu> Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: Ksenija Stanojevic <KsenijaS@users.noreply.github.com> [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
Summary: Pull Request resolved: #56163 * [ONNX] Improve index_put symbolic to handle singular Bool updates (#53690) Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes #53507 * [ONNX] Support primitive type input/outputs and attributes (#53550) Support primitive type attributes. Needed for Silero model. * [ONNX] Fix if output shape mismatch error & Fix graph input directly used as output (#53219) Fix if output shape mismatch error & Fix graph input directly used as output * Add support for hann_window operator. * [ONNX] Replace decomposeLinear pre process pass with a symbolic (#53077) Replace decomposeLinear pre process pass with a symbolic * Add a test case for dtype is None. * Resolve flake8 issue. * Remove one unused test case. * Add support for hann_window operator. * Add a test case for dtype is None. * Remove one unused test case. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D27866145 Pulled By: SplitInfinity fbshipit-source-id: e0b43df9ecd1a95cd7ac297213aba453bbaf2913 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Negin Raoof <neginmr@utexas.edu> Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: Ksenija Stanojevic <KsenijaS@users.noreply.github.com>
heitorschueroff
pushed a commit
that referenced
this pull request
Apr 21, 2021
Summary: Pull Request resolved: #56163 * [ONNX] Improve index_put symbolic to handle singular Bool updates (#53690) Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes #53507 * [ONNX] Support primitive type input/outputs and attributes (#53550) Support primitive type attributes. Needed for Silero model. * [ONNX] Fix if output shape mismatch error & Fix graph input directly used as output (#53219) Fix if output shape mismatch error & Fix graph input directly used as output * Add support for hann_window operator. * [ONNX] Replace decomposeLinear pre process pass with a symbolic (#53077) Replace decomposeLinear pre process pass with a symbolic * Add a test case for dtype is None. * Resolve flake8 issue. * Remove one unused test case. * Add support for hann_window operator. * Add a test case for dtype is None. * Remove one unused test case. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D27866145 Pulled By: SplitInfinity fbshipit-source-id: e0b43df9ecd1a95cd7ac297213aba453bbaf2913 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Negin Raoof <neginmr@utexas.edu> Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: Ksenija Stanojevic <KsenijaS@users.noreply.github.com>
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…#56163) Summary: Pull Request resolved: pytorch#56163 * [ONNX] Improve index_put symbolic to handle singular Bool updates (pytorch#53690) Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below ``` mask[indices] = True ``` Fixes pytorch#53507 * [ONNX] Support primitive type input/outputs and attributes (pytorch#53550) Support primitive type attributes. Needed for Silero model. * [ONNX] Fix if output shape mismatch error & Fix graph input directly used as output (pytorch#53219) Fix if output shape mismatch error & Fix graph input directly used as output * Add support for hann_window operator. * [ONNX] Replace decomposeLinear pre process pass with a symbolic (pytorch#53077) Replace decomposeLinear pre process pass with a symbolic * Add a test case for dtype is None. * Resolve flake8 issue. * Remove one unused test case. * Add support for hann_window operator. * Add a test case for dtype is None. * Remove one unused test case. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D27866145 Pulled By: SplitInfinity fbshipit-source-id: e0b43df9ecd1a95cd7ac297213aba453bbaf2913 Co-authored-by: Shubham Bhokare <32080845+shubhambhokare1@users.noreply.github.com> Co-authored-by: Negin Raoof <neginmr@utexas.edu> Co-authored-by: Bowen Bao <bowbao@microsoft.com> Co-authored-by: Ksenija Stanojevic <KsenijaS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for cases where the updates to the index_put node is a single Bool value, such as the case shown below
Fixes #53507