Start addressing pep8 lint #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if we want to enforce pep8 strictly. @soumith @colesbury? |
Merged
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Mar 16, 2020
* enable miopen 3d conv in caffe2 * minor bug fixes with setTensorDescriptor * added test cases for conv3d in miopen * removed unnecessary white spaces * refactored conv code to have one common api for 2d & 3d * fixed bias tensor descriptor issue * fixed messages
KyleCZH
pushed a commit
to KyleCZH/pytorch
that referenced
this pull request
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3.
This PR only fixes lint in a single file, but you can fix it all with:
That diff would look pretty terrifying since it would touch every file in the project. I thought I'd start out slow.