Fix all pep8 lint

[lukeyeager]

Close #3

This is a follow-up to #575. This is that terrifying diff I was talking about.

To reduce the terror, I've split this up into several commits:

1. Fix most lint automatically with autopep8 (as I did with Fix remaining Python lint NVIDIA/DIGITS#1207)
2. Manually fix all the lint with an obvious fix
3. Manually fix lint in the docstrings that could potentially break the auto-generated documentation
   • I think I got it right, but I'd like for someone who understand the documentation generation tool to have a look

[lukeyeager]

I'd like to wait for #614 before merging this.

[apaszke]

Can you rebase the PR to have the new travis config?

[desimone]

Big fan of pep8'ing things. The less mental space assigned to formatting -- whatever defaults are chosen -- the better in my opinion.

That said, since this is probably as good of a time as any to ask, why 120 vs 79 for column limit? I personally go back and forth, but often wonder if the horizontal space gained is worth the exception from community norm.

[apaszke]

I could never understand why is it 79, not 80...

[lukeyeager]

why 120 vs 79 for column limit?

I like the GitHub rule: GitHub has a max line length of ~120 when displaying diffs.

Happy to change to whichever value the @pytorch folks like.

[soumith]

let's not discuss 120 vs 79 anymore :D
120 sounds fine, thanks.

[apaszke]

@lukeyeager I've pushed a fix for a flaky Sqrt test and it's conflicting with your changes now. Can you reabse them once more please?

[lukeyeager]

Rebased. I discarded my conflicting changes, took yours, then ran autopep8 on top of them again.

[apaszke]

@pytorchbot add to whitelist

[apaszke]

Thanks!

[apaszke]

@lukeyeager Does the config have to be in setup.cfg? It's annoying because it creates a terminal autocomplete conflict with setup.py and that's used a lot.

[lukeyeager]

I know, it bugs me too. Here are the other options:

• ./tox.ini
• ./.pep8 (deprecated)

So maybe tox.ini? I've seen major libraries use either one.

[apaszke]

Hmmm ok, we're not using tox (SciPy is), so maybe let's keep it as is.

[ngimel]

@lukeyeager, would putting setup.cfg into tools directory and passing --config=tools to autopep8 be an option?

[lukeyeager]

Good point, that's an option too. The advantage of keeping the config file in a standard location is that you can call pep8 . from anywhere in the tree and it will pick up the config for the project.

[apaszke]

It's not that bad, let's keep it in the root for now. We'll have to start using pep8 a lot from now on.

[colesbury]

If tox.ini works with pep8 let's just change the name. (It sounds like it's officially supported from the pep8 docs). The autocomplete for setup has been bugging me all day.