-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ao] fixing public v private for quantize.py #86023
Conversation
Summary: just needed to add __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86023
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 7 PendingAs of commit b211069: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
"quantize_qat", | ||
"convert", | ||
"swap_module", | ||
"get_observer_dict", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like this function doesn't belong here, probably should put this in some util files I think
Summary: just needed to add __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
Summary: just needed to add __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
@pytorchmergebot merge |
@pytorchbot successfully started a merge job. Check the current status here. |
Summary: just needed to add __all__ Pull Request resolved: #86023 Approved by: https://github.com/jerryzh168 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/14db44ad72f0110b484c0c8aaf520e110cc91f53 Test plan from GitHub: python test/test_public_bindings.py Reviewed By: seemethere Differential Revision: D40166940 Pulled By: seemethere fbshipit-source-id: 9bbfd902e0be9e7c2454c417405447eb1e61d0c8
Stack from ghstack (oldest at bottom):
Summary: just needed to add all
Test Plan: python test/test_public_bindings.py
Reviewers:
Subscribers:
Tasks:
Tags: