[ao] fixing public v private for fx.backend_config_utils.py #86037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86037
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f674936: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 30, 2022
HDCharles
added a commit
that referenced
this pull request
Sep 30, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f3ff07179e97e944bad5b526d614af82bb45be12 Pull Request resolved: #86037
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 3, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ef1d489ae6487527241ca1dfe6ce50f403da1ee9 Pull Request resolved: #86037
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
HDCharles
added
topic: not user facing
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
reviewed
Oct 5, 2022
| @@ -137,6 +137,7 @@ def get_native_quant_patterns(additional_quant_patterns: Dict[Pattern, Quantizer | |||
| get_pattern_to_quantize_handlers.__module__ = "torch.ao.quantization.fx.backend_config_utils" | |||
|
|
|||
| __all__ = [ | |||
| "get_quantize_handler_cls", | |||
There was a problem hiding this comment.
this is a helper function I think, we can probably make it private, should probably be in a separate PR though
jerryzh168
approved these changes
Oct 5, 2022
|
@pytorchmergebot merge |
|
@pytorchbot successfully started a merge job. Check the current status here. |
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 5, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 618a66b851d8567dc41e98472ecd455e06ff96e1 Pull Request resolved: #86037
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 6, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 576a59b12595aef909d7ee252c444c9c1f01c524 Pull Request resolved: #86037
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 6, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 69738917f1abd6190e285dbef0f4bdcff71872ca Pull Request resolved: #86037
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 6, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4f83687633a6e2273b6288e9b3fe1e11d87b2886 Pull Request resolved: #86037
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 7, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9517f5b80dfc8aa9176d8d170ba7f631c3d58498 Pull Request resolved: #86037
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 10, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ad475e0c7aa5224ba6827f893ee57b77e07ebaec Pull Request resolved: #86037
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 12, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 96b4dd17d4ab735a754f38f0333fd459af081645 Pull Request resolved: #86037
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 12, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: af8db51ac8768855e694b86cbc9dd61a75b611d4 Pull Request resolved: #86037
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Oct 13, 2022
Summary: just added a missing function to __all__ Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f78696c712500ddc6215606f2b96c48718178ade Pull Request resolved: #86037
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: just added a missing function to all
Test Plan: python test/test_public_bindings.py
Reviewers:
Subscribers:
Tasks:
Tags: