[ao] fixing public v private for qconfig.py #86026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: no changes, just removed the exception for this file, someone had already fixed the actual file Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86026
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 2 PendingAs of commit 6b9a45d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 30, 2022
This was referenced Sep 30, 2022
Summary: no changes, just removed the exception for this file, someone had already fixed the actual file Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
HDCharles
added
topic: not user facing
Summary: no changes, just removed the exception for this file, someone had already fixed the actual file Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
approved these changes
Oct 5, 2022
Summary: no changes, just removed the exception for this file, someone had already fixed the actual file Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: no changes, just removed the exception for this file, someone had already fixed the actual file Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: no changes, just removed the exception for this file, someone had already fixed the actual file Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Summary: no changes, just removed the exception for this file, someone had already fixed the actual file Pull Request resolved: #86026 Approved by: https://github.com/jerryzh168 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/facf210f9a6e98bdeb2ec343b8f16c5bb047c4ce Test plan from GitHub: python test/test_public_bindings.py Reviewed By: seemethere Differential Revision: D40167167 Pulled By: seemethere fbshipit-source-id: bbbe8eb95114285c99c9f306ed6e5a853d7beb01
Rick0317
pushed a commit
to Rick0317/pytorch
that referenced
this pull request
Oct 18, 2022
Summary: no changes, just removed the exception for this file, someone had already fixed the actual file Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3f00f2c77f9079513fc13f196947f0e6b13cbd00 Pull Request resolved: pytorch/pytorch#86026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: no changes, just removed the exception for this file, someone
had already fixed the actual file
Test Plan: python test/test_public_bindings.py
Reviewers:
Subscribers:
Tasks:
Tags: