Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataPipe] Fix missing functional name for FileLister #86497

Closed
wants to merge 3 commits into from
Closed

[DataPipe] Fix missing functional name for FileLister #86497

wants to merge 3 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Oct 7, 2022 •
edited by pytorchmergebot

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 7, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86497

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 2 Pending

As of commit b9b18cb:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Oct 7, 2022
NivekT added a commit that referenced this pull request Oct 7, 2022
@NivekT
[DataPipe] Fix missing functional name for FileLister
adc5aa8 
ghstack-source-id: 398e4bee814363332358441bd64e3cfaa06c456f
Pull Request resolved: #86497
@NivekT NivekT added the topic: docs topic category label Oct 7, 2022
@NivekT NivekT requested a review from ejguan October 7, 2022 21:31
@NivekT
Copy link
Contributor Author

NivekT commented Oct 7, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/nivekt/54/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/86497)

pytorchmergebot pushed a commit that referenced this pull request Oct 7, 2022
@NivekT
[DataPipe] Fix missing functional name for FileLister
f6f4103 
ghstack-source-id: d4f257318887e8432b32c977569a9a05141ec90c
Pull Request resolved: #86497
ejguan
ejguan approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 14, 2022
@NivekT
Copy link
Contributor Author

NivekT commented Oct 14, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@NivekT
Copy link
Contributor Author

NivekT commented Oct 17, 2022

@pytorchbot merge

@NivekT
Copy link
Contributor Author

NivekT commented Oct 17, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/nivekt/54/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/86497)

pytorchmergebot pushed a commit that referenced this pull request Oct 17, 2022
@NivekT
[DataPipe] Fix missing functional name for FileLister
02286ad 
ghstack-source-id: 39cdc9a1cf451691e572917806c3ff43b309d710
Pull Request resolved: #86497
@NivekT
Copy link
Contributor Author

NivekT commented Oct 17, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

NivekT added a commit that referenced this pull request Oct 17, 2022
@NivekT
[DataPipe] Fix missing functional name for FileLister (#86497)
5cd3208 
Pull Request resolved: #86497
Approved by: https://github.com/ejguan
This was referenced Oct 17, 2022
Merged
Closed
pytorchmergebot pushed a commit that referenced this pull request Oct 18, 2022
@NivekT @pytorchmergebot
[DataPipe] Fix missing functional name for FileLister (#86497)
7d3ebc3 
Pull Request resolved: #86497
Approved by: https://github.com/ejguan
malfet pushed a commit that referenced this pull request Oct 18, 2022
@NivekT
[Release 1.13.0][DataPipe] Documentation and interface fix (#87140)
eda8263 
* [DataPipe] Fix missing functional name for FileLister (#86497)

Pull Request resolved: #86497
Approved by: https://github.com/ejguan

* [DataPipe] Fixing interface generation in setup.py (#87081)

Based on the artifact generated on this [page](https://hud.pytorch.org/pr/87081), I downloaded [[s3] linux-focal-py3.7-clang7-asan/artifacts.zip](https://gha-artifacts.s3.amazonaws.com/pytorch/pytorch/3266430083/linux-focal-py3.7-clang7-asan/artifacts.zip) (1.14 GB) and unpacked it. `torch.utils.data.datapipes.datapipe.pyi` does exist. I believe this means the file should be part of the distribution.

I also did `wheel unpack ***.whl` to confirm the existence of the file.
Pull Request resolved: #87081
Approved by: https://github.com/ejguan
@facebook-github-bot facebook-github-bot deleted the gh/nivekt/54/head branch June 8, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejguan ejguan ejguan approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: dataloader release notes category topic: docs topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NivekT @pytorchmergebot @ejguan