[DataPipe] Fixing interface generation in setup.py #87081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87081
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 26862af: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NivekT
added a commit
that referenced
this pull request
Oct 17, 2022
ghstack-source-id: 6483beb25928901fd0d3b59859ef96bfd909cc1b Pull Request resolved: #87081
NivekT
added
module: data
[ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Oct 17, 2022
ghstack-source-id: 9a270adc5a2ccc6d60aef2a2a63b204aa397c2d3 Pull Request resolved: #87081
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
NivekT
added a commit
that referenced
this pull request
Oct 17, 2022
Based on the artifact generated on this [page](https://hud.pytorch.org/pr/87081), I downloaded [[s3] linux-focal-py3.7-clang7-asan/artifacts.zip](https://gha-artifacts.s3.amazonaws.com/pytorch/pytorch/3266430083/linux-focal-py3.7-clang7-asan/artifacts.zip) (1.14 GB) and unpacked it. `torch.utils.data.datapipes.datapipe.pyi` does exist. I believe this means the file should be part of the distribution. I also did `wheel unpack ***.whl` to confirm the existence of the file. Pull Request resolved: #87081 Approved by: https://github.com/ejguan
This was referenced Oct 17, 2022
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 18, 2022
Based on the artifact generated on this [page](https://hud.pytorch.org/pr/87081), I downloaded [[s3] linux-focal-py3.7-clang7-asan/artifacts.zip](https://gha-artifacts.s3.amazonaws.com/pytorch/pytorch/3266430083/linux-focal-py3.7-clang7-asan/artifacts.zip) (1.14 GB) and unpacked it. `torch.utils.data.datapipes.datapipe.pyi` does exist. I believe this means the file should be part of the distribution. I also did `wheel unpack ***.whl` to confirm the existence of the file. Pull Request resolved: #87081 Approved by: https://github.com/ejguan
malfet
pushed a commit
that referenced
this pull request
Oct 18, 2022
* [DataPipe] Fix missing functional name for FileLister (#86497) Pull Request resolved: #86497 Approved by: https://github.com/ejguan * [DataPipe] Fixing interface generation in setup.py (#87081) Based on the artifact generated on this [page](https://hud.pytorch.org/pr/87081), I downloaded [[s3] linux-focal-py3.7-clang7-asan/artifacts.zip](https://gha-artifacts.s3.amazonaws.com/pytorch/pytorch/3266430083/linux-focal-py3.7-clang7-asan/artifacts.zip) (1.14 GB) and unpacked it. `torch.utils.data.datapipes.datapipe.pyi` does exist. I believe this means the file should be part of the distribution. I also did `wheel unpack ***.whl` to confirm the existence of the file. Pull Request resolved: #87081 Approved by: https://github.com/ejguan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Based on the artifact generated on this page, I downloaded [s3] linux-focal-py3.7-clang7-asan/artifacts.zip (1.14 GB) and unpacked it.
torch.utils.data.datapipes.datapipe.pyidoes exist. I believe this means the file should be part of the distribution.I also did
wheel unpack ***.whlto confirm the existence of the file.