[ONNX] Fix scalar_type_analysis metadata for copied constant #86716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86716
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3ff829b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
BowenBao
added
module: onnx
justinchuby
reviewed
Oct 11, 2022
Fix the source of metadata for copied constant. Since the constant is being implicitly casted, it makes more sense to assign code location and etc with the user node. This issue was discovered in #86627. This PR also adds unit test coverage for scope information of nodes when they are altered by CSE and related passes. [ghstack-poisoned]
BowenBao
commented
Oct 12, 2022
BowenBao
added
the
onnx-needs-import
malfet
approved these changes
Oct 13, 2022
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BowenBao
added a commit
that referenced
this pull request
Oct 13, 2022
Fix the source of metadata for copied constant. Since the constant is being implicitly casted, it makes more sense to assign code location and etc with the user node. This issue was discovered in #86627. This PR also adds unit test coverage for scope information of nodes when they are altered by CSE and related passes. Pull Request resolved: #86716 Approved by: https://github.com/thiagocrepaldi, https://github.com/malfet
This was referenced Oct 13, 2022
malfet
pushed a commit
that referenced
this pull request
Oct 18, 2022
…#86923) Fix the source of metadata for copied constant. Since the constant is being implicitly casted, it makes more sense to assign code location and etc with the user node. This issue was discovered in #86627. This PR also adds unit test coverage for scope information of nodes when they are altered by CSE and related passes. Pull Request resolved: #86716 Approved by: https://github.com/thiagocrepaldi, https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fix the source of metadata for copied constant. Since the constant is being implicitly casted,
it makes more sense to assign code location and etc with the user node.
This issue was discovered in #86627. This PR also adds unit test coverage for scope
information of nodes when they are altered by CSE and related passes.