Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Fix scalar_type_analysis metadata for copied constant (#86716) #86923

Merged
merged 1 commit into from Oct 18, 2022

Conversation

BowenBao
Copy link
Collaborator

Fix the source of metadata for copied constant. Since the constant is being implicitly casted, it makes more sense to assign code location and etc with the user node. This issue was discovered in #86627. This PR also adds unit test coverage for scope information of nodes when they are altered by CSE and related passes.

Pull Request resolved: #86716
Approved by: https://github.com/thiagocrepaldi, https://github.com/malfet

Fixes #ISSUE_NUMBER

Fix the source of metadata for copied constant. Since the constant is being implicitly casted,
it makes more sense to assign code location and etc with the user node.
This issue was discovered in #86627. This PR also adds unit test coverage for scope
information of nodes when they are altered by CSE and related passes.

Pull Request resolved: #86716
Approved by: https://github.com/thiagocrepaldi, https://github.com/malfet
@BowenBao BowenBao requested a review from abock as a code owner October 13, 2022 18:27
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 13, 2022
@BowenBao
Copy link
Collaborator Author

@malfet please take a look at this cherry pick, it fixes a regression for exporter.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2022
@malfet malfet merged commit 894bad7 into release/1.13 Oct 18, 2022
@malfet malfet deleted the bowbao/release1.13/cp2 branch October 18, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request open source release notes: onnx torch.onnx related changes that should show up in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants