Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vmap support for slogdet; fix regression from functorch 0.2.1 (#8… #86902

Merged
merged 1 commit into from
Oct 13, 2022

Commits on Oct 13, 2022

  1. Add vmap support for slogdet; fix regression from functorch 0.2.1 (#8…

    …6815)
    
    This PR adds vmap support for slogdet -- slogdet just decomposes into
    linalg.slogdet.
    
    This fixes a regression from functorch 0.2.1 (slogdet had a batching
    rule then, and doesn't anymore). We didn't catch the regression because
    it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one
    before).
    
    Test Plan:
    - new one-off test.
    Pull Request resolved: #86815
    Approved by: https://github.com/samdow
    zou3519 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    089e0e5 View commit details
    Browse the repository at this point in the history