Add vmap support for slogdet; fix regression from functorch 0.2.1 #86815
Conversation
This PR adds vmap support for slogdet -- slogdet just decomposes into linalg.slogdet. This fixes a regression from functorch 0.2.1 (slogdet had a batching rule then, and doesn't anymore). We didn't catch the regression because it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one before). Test Plan: - new one-off test. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86815
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 3610061: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR adds vmap support for slogdet -- slogdet just decomposes into linalg.slogdet. This fixes a regression from functorch 0.2.1 (slogdet had a batching rule then, and doesn't anymore). We didn't catch the regression because it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one before). Test Plan: - new one-off test. ghstack-source-id: a41d5926a7febc50b462842fd54317aba75d2fc3 Pull Request resolved: #86815
test/functorch/test_vmap.py
Outdated
| # There's no OpInfo for this | ||
| B = 2 | ||
| x = torch.randn(2, 5, 5, device=device) | ||
| self.vmap_outplace_test(torch.slogdet, (x,), {}, (0,)) |
There was a problem hiding this comment.
Do we also want to call check_vmap_fallback since IIUC it was working before but raising the warning
There was a problem hiding this comment.
Good catch. I forgot that vmap_outplace_test doesn't do the check_vmap_fallback
…h 0.2.1" This PR adds vmap support for slogdet -- slogdet just decomposes into linalg.slogdet. This fixes a regression from functorch 0.2.1 (slogdet had a batching rule then, and doesn't anymore). We didn't catch the regression because it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one before). Test Plan: - new one-off test. [ghstack-poisoned]
This PR adds vmap support for slogdet -- slogdet just decomposes into linalg.slogdet. This fixes a regression from functorch 0.2.1 (slogdet had a batching rule then, and doesn't anymore). We didn't catch the regression because it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one before). Test Plan: - new one-off test. ghstack-source-id: d7d300bd6c3ea70df4ad1c3431d2d4baf20cf2fe Pull Request resolved: #86815
|
@pytorchbot merge -f "unrelated failure" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Hey @zou3519. |
…6815) This PR adds vmap support for slogdet -- slogdet just decomposes into linalg.slogdet. This fixes a regression from functorch 0.2.1 (slogdet had a batching rule then, and doesn't anymore). We didn't catch the regression because it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one before). Test Plan: - new one-off test. Pull Request resolved: #86815 Approved by: https://github.com/samdow
…6815) (#86902) This PR adds vmap support for slogdet -- slogdet just decomposes into linalg.slogdet. This fixes a regression from functorch 0.2.1 (slogdet had a batching rule then, and doesn't anymore). We didn't catch the regression because it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one before). Test Plan: - new one-off test. Pull Request resolved: #86815 Approved by: https://github.com/samdow
Stack from ghstack:
This PR adds vmap support for slogdet -- slogdet just decomposes into
linalg.slogdet.
This fixes a regression from functorch 0.2.1 (slogdet had a batching
rule then, and doesn't anymore). We didn't catch the regression because
it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one
before).
Test Plan: