Add vmap support for slogdet; fix regression from functorch 0.2.1 (#8… #86902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6815) This PR adds vmap support for slogdet -- slogdet just decomposes into linalg.slogdet. This fixes a regression from functorch 0.2.1 (slogdet had a batching rule then, and doesn't anymore). We didn't catch the regression because it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one before). Test Plan: - new one-off test. Pull Request resolved: #86815 Approved by: https://github.com/samdow
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86902
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 089e0e5: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Note for reviewers:
|
malfet
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…6815)
This PR adds vmap support for slogdet -- slogdet just decomposes into linalg.slogdet.
This fixes a regression from functorch 0.2.1 (slogdet had a batching rule then, and doesn't anymore). We didn't catch the regression because it seems like slogdet doesn't have an OpInfo (I'm not sure if it had one before).
Test Plan:
Pull Request resolved: Add vmap support for slogdet; fix regression from functorch 0.2.1 #86815
Approved by: https://github.com/samdow