Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Fix scalar_type_analysis metadata for copied constant (#86716) #86923

Merged
merged 1 commit into from
Oct 18, 2022
Merged

[ONNX] Fix scalar_type_analysis metadata for copied constant (#86716) #86923

merged 1 commit into from
Oct 18, 2022

Commits on Oct 13, 2022

  1. [ONNX] Fix scalar_type_analysis metadata for copied constant (#86716) 

    Fix the source of metadata for copied constant. Since the constant is being implicitly casted,
it makes more sense to assign code location and etc with the user node.
This issue was discovered in #86627. This PR also adds unit test coverage for scope
information of nodes when they are altered by CSE and related passes.

Pull Request resolved: #86716
Approved by: https://github.com/thiagocrepaldi, https://github.com/malfet
    @BowenBao
    BowenBao committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    12acf01 View commit details
    Browse the repository at this point in the history