Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Use nested namespaces in sparse #97581

Closed
wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Mar 25, 2023

🤖 Generated by Copilot at 59a5205

This pull request refactors the namespace declarations in several files under aten/src/ATen/native/sparse to use a more concise and consistent syntax. This improves the readability and reusability of the sparse tensor operations code.

Also, do not rely on deprecated TensorBase::data and instead use TensorBase::data_ptr

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Mar 25, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 25, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97581

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 63394b7:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added the topic: not user facing topic category label Mar 25, 2023
@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 26, 2023
@malfet
Copy link
Contributor Author

malfet commented Mar 26, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-bionic-cuda11.8-py3.10-gcc7 / test (default, 3, 5, linux.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor Author

malfet commented Mar 26, 2023

@pytorchbot merge -f "TestTorch::test_typed_storage_deprecation_warning is due to trunk regressions, perhaps fixed by #97628 "

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: sparse release notes category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants