Specify file encoding in test_torch.py #97628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to fix ``` UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 5260: ordinal not in range(128) ``` in https://github.com/pytorch/pytorch/actions/runs/4522628359/jobs/7965372405 In general, it's a good practice to explicitly specify encoding
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97628
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 69aa24e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
dagitses
approved these changes
Mar 26, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kit1980
approved these changes
Mar 26, 2023
This was referenced Mar 26, 2023
dilililiwhy
pushed a commit
to dilililiwhy/pytorch
that referenced
this pull request
Mar 27, 2023
Attempt to fix ``` UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 5260: ordinal not in range(128) ``` in https://github.com/pytorch/pytorch/actions/runs/4522628359/jobs/7965372405 In general, it's a good practice to explicitly specify encoding, as otherwise it depends on environment variable and makes tests failures unpredicatble Pull Request resolved: pytorch#97628 Approved by: https://github.com/dagitses, https://github.com/kit1980
kurtamohler
pushed a commit
to kurtamohler/pytorch
that referenced
this pull request
Apr 8, 2023
Attempt to fix ``` UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 5260: ordinal not in range(128) ``` in https://github.com/pytorch/pytorch/actions/runs/4522628359/jobs/7965372405 In general, it's a good practice to explicitly specify encoding, as otherwise it depends on environment variable and makes tests failures unpredicatble Pull Request resolved: pytorch#97628 Approved by: https://github.com/dagitses, https://github.com/kit1980
This was referenced Apr 10, 2023
atalman
pushed a commit
that referenced
this pull request
Apr 18, 2023
* Only warn once for TypedStorage deprecation (#97379) Fixes #97207 Pull Request resolved: #97379 Approved by: https://github.com/ezyang * Specify file encoding in test_torch.py (#97628) Attempt to fix ``` UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 5260: ordinal not in range(128) ``` in https://github.com/pytorch/pytorch/actions/runs/4522628359/jobs/7965372405 In general, it's a good practice to explicitly specify encoding, as otherwise it depends on environment variable and makes tests failures unpredicatble Pull Request resolved: #97628 Approved by: https://github.com/dagitses, https://github.com/kit1980 --------- Co-authored-by: Nikita Shulga <nshulga@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix
in https://github.com/pytorch/pytorch/actions/runs/4522628359/jobs/7965372405
In general, it's a good practice to explicitly specify encoding, as otherwise it depends on environment variable and makes tests failures unpredicatble