[BE] Cleanup CMake flag suppressions #97584
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97584
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 5a4cfe5: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Use `append_cxx_flag_if_supported` to determine whether or not `-Werror` is supported Do not suppress deprecation warnings if glog is not used/installed. Do not guard calls to `append_cxx_flag_if_supported` with `if(CLANG)` or `if(GCC)`
Remove `-Wno-error`
malfet
force-pushed
the
malfet/be-cleanup-cmake
branch
from
bd3dfd2
to
e9da87d
Compare
github-actions
bot
added
the
module: mkldnn
malfet
added
ciflow/trunk
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / linux-bionic-cuda11.8-py3.10-gcc7 / test (default, 3, 5, linux.4xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "Builds are green and test_torch was fixed by #97628" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Use
append_cxx_flag_if_supportedto determine whether or not-Werroris supportedDo not suppress deprecation warnings if glog is not used/installed, as the way check is written right now, it will suppress deprecations even if
glogis not installed.Similarly, do not suppress deprecations on MacOS simply because we are compiling with protobuf.
Fix deprecation warnings in:
MTLResourceOptionCPUCacheModeDefault->MTLResourceCPUCacheModeDefaultCacheTYPED_TEST_CASE->TYPED_TEST_SUITEcodegen/onednn/interface.cpp, by using passingStackby reference rathern than pointer.Do not guard calls to
append_cxx_flag_if_supportedwithif(CLANG)orif(GCC).Fix some deprecated calls in
Metalhide more complex exception underC10_CLANG_DIAGNOSTIC_IGNOREcc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @jgong5 @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen