Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Publish wheels for OS X and ARM64 #1312

Closed
Sitin opened this issue Jun 25, 2023 · 7 comments · May be fixed by #1338
Closed

[Feature Request] Publish wheels for OS X and ARM64 #1312

Sitin opened this issue Jun 25, 2023 · 7 comments · May be fixed by #1338
Assignees
Labels
enhancement New feature or request

Comments

@Sitin
Copy link

Sitin commented Jun 25, 2023

It seems that the torchrl can run at arm64 and Apple Silicone. It would be nice to have the same requirements.txt/Pipfile at all platforms where this library can be executed.

@Sitin Sitin added the enhancement New feature or request label Jun 25, 2023
@vmoens
Copy link
Contributor

vmoens commented Jun 27, 2023

cc @osalpekar
How should we proceed to have this?

@osalpekar
Copy link
Member

@Sitin @vmoens Wanted to clarify the ask here - IIUC all the wheels build requirements are explicitly listed here: https://github.com/pytorch/rl/blob/main/setup.py#L208, and are unified across platforms. Is the ask for official binaries for arm64/Apple Silicon?

@hyerra
Copy link
Contributor

hyerra commented Jun 29, 2023

I am also running into this issue, and not sure if this is the same, but essentially when I try to install torchrl on my Apple Silicon Mac, I run into this:

pip install torchrl
ERROR: Could not find a version that satisfies the requirement torchrl (from versions: none)
ERROR: No matching distribution found for torchrl

I have to pip install using the url directly using this command:

pip install https://github.com/pytorch/rl.git

pip install torchrl works on other machines though like Windows. I'm not sure if this thread is relevant? It looks like they added the universal packages like 2 weeks ago and the last version of torchrl was before that so maybe publishing a new version would fix?

@Sitin
Copy link
Author

Sitin commented Jun 29, 2023

@osalpekar, just want to clarify. As @hyerra mentioned, while it is possible to install pytorchlr on M1/M2 from the repository but I can't do the same using package version (i.e. pip install torchrl).

When it comes to the implementation, then platform-specific wheels with prebuilt binnaries would be my favorite options (and probably the easiest for you since CircleCI has M1 executors).

@osalpekar
Copy link
Member

Thanks for clarifying. The issue is essentially that we don't publish first-party wheels for Apple Silicon or Arm64, but adding support is straightforward (at least for Apple Silicon).

cc @atalman We should add Nova pipelines for TorchRL for M1, as well as for aarch64 once those are ready.

The reason the pip install works out of the box for Windows is that we are publishing wheels for Linux/Windows/Mac x86. The github link works since that seems to just check out the repo and build the wheel from source locally.

@Sitin
Copy link
Author

Sitin commented Jun 29, 2023

@osalpekar, than you very much! Can't wait to finally fix my dependecy mess.

@vmoens vmoens linked a pull request Jun 30, 2023 that will close this issue
@vmoens
Copy link
Contributor

vmoens commented Oct 9, 2023

v0.2.0 now includes wheels for M1!
Feel free to reopen if issues persist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants