-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.9 #33
Milestone
Comments
jansel
modified the milestones:
Increase Python Coverage,
Python Coverage,
Inference Product
Mar 16, 2022
Looks like 3.9 also added Both of those will require changes to _eval_frame.c |
@hsrussell is taking a look at this one |
|
Fixed by #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The process for adding support for Python 3.9 is as follows.
First, examine the 10 new bytecodes in 3.9:
RERAISE
raising exceptions is currently not supported and breaks the graph. So this can just call
unimplemented()
for now. See issue pytorch/pytorch#93720 for more on exceptions.WITH_EXCEPT_START
might affect support for
with no_grad():
and related opsLOAD_ASSERTION_ERROR
LIST_TO_TUPLE
LIST_EXTEND
SET_UPDATE
DICT_UPDATE
DICT_MERGE
IS_OP
CONTAINS_OP
these are all simple aliases for things TorchDynamo already supports and should be easy to handle
Next, update the versions supported in
setup.py
so the build works.Next, iteratively add support for ops and fix issues until all tests pass.
pytest tests
to run tests.Next, iteratively fix issues in ./torchbench.py until all models pass and match the coverage of Python 3.8
The text was updated successfully, but these errors were encountered: