Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] cpu_only fbgemm won't compile "permute_pooled_embs_auto_grad" #160

Closed
RabbitWhite1 opened this issue Mar 17, 2022 · 3 comments
Closed

Comments

@RabbitWhite1
Copy link

The used fbgemm @ c3a26e1 is buggy when compiling with "--cpu_only".

As specified in CMakeLists.txt, "src/permute_pooled_embedding_ops_gpu.cpp" will only compile when "NOT FBGEMM_CPU_ONLY", which means the method "permute_pooled_embs_auto_grad" won't be generated when "--cpu_only". However, this method is used by column_wise sharding.

To correctly support "--cpu_only", see the pr in FBGEMM#987

@jianyuh
Copy link
Member

jianyuh commented Mar 18, 2022

Thanks @RabbitWhite1 for reporting this issue! We are working on fixing this issue with pytorch/FBGEMM#950 as you mentioned. Currently the major blocker on landing the PR is due to some internal backward compatibility issues. Will push on landing it soon. cc @geyyer

@geyyer
Copy link
Contributor

geyyer commented Mar 30, 2022

PR pytorch/FBGEMM#987 fixing the issue was landed.

@colin2328
Copy link
Contributor

Thanks @geyyer . Closing this issue. @RabbitWhite1 feel free to file another issue if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants